Closed (fixed)
Project:
Flag
Version:
7.x-3.x-dev
Component:
Flag core
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Feb 2014 at 19:28 UTC
Updated:
9 Mar 2014 at 10:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
joachim commentedComment #2
joachim commentedTests pass, but I'd appreciate a review by a human as well, given this provides critical functionality.
Comment #3
socketwench commentedWorks for me. Tests clean too.
Comment #4
joachim commentedThanks for the review.
I've committed #2203047: FlagLinkTypeConfirmTestCase doesn't check a flagging happened, which adds checking of the flagging entity to the confirm link test -- this is the other place outside of the flag class which calls new_flagging(), which is altered by this patch.
This also goes some way towards fixing #2196055: entity hooks don't get passed a proper Flagging entity -- and in fact may do so entirely.
Comment #5
joachim commentedOngoing work in this area at #2202969: clean up flag() and its low-level helpers.