Updated: Comment 0

Problem/Motivation

If you export your panel into a feature and revert the existing entry in the database breakpoint_panels simply does not work anymore.

Proposed resolution

  • Instead of relying on the DID (display ID) we need to load the full task handler object
  • In theory hook_panels_pane_content_alter() should somehow know the context of the used task handler (aka. the machine name of the panel page)
  • page_manager_get_current_page() is an alternative way to get the current page/task handler information. Let's use that to store the task ID and task subID (for example 'page' and 'name_of_the_page')
  • On the ajax callback load the task object from the task ID
  • Once we have the task we can load the used task handler and from there get to the display object and continue like now
  • We really should not use exit() but rely on drupal_exit() to also execute other end-of-request tasks.
  • The fun starts as we have to adapt the modal setting as well (similar strategy)

Remaining tasks

User interface changes

API changes

Comments

dawehner’s picture

Status: Active » Needs review
StatusFileSize
new3.06 KB

.

dawehner’s picture

Issue summary: View changes
StatusFileSize
new5.75 KB

.

hydra’s picture

Status: Needs review » Reviewed & tested by the community

This fixed a half ton of issues for me and needs defenetly be commited in order to use this module. Thx for this!

hydra’s picture

The 2. patch only works after applying https://drupal.org/node/2186159

svajlenka’s picture

The patch in #2 is fantastic and should absolutely get committed!

svajlenka’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new8.21 KB

Ah, I ran into some issues with the above patch.

* IPE integration was not updated to use the task/subtask id for the task handler
* In cases where there was no subtask (in my case this was node_view) the patch failed to save breakpoint configuration for the pane

I've attached a patch (to apply after #2) for review, I've also ran the module through code review (using --minor) to clean up the module in general.

svajlenka’s picture

reroll of my above patch with an additional fix for the no subtask id situation...

svajlenka’s picture

I just keep finding small issues. Attached is a reroll with an additional fix (for the display) of panes with no subtask.

svajlenka’s picture

Status: Needs review » Fixed

Committed patches 2 and 8. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.