Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
15 Feb 2014 at 08:19 UTC
Updated:
29 Jul 2014 at 23:22 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
divesh.kumar commentedPatch is attached.
Comment #2
thedavidmeister commentedThanks @divesh, we actually use a slightly different format to simplify things with namespace aliases so we can just write
String::checkPlain()(without the extended prefix). I added instructions to the parent issue just now, that should hopefully make things clearer.The code we want here is actually taking part of the patch at #2089465: Convert all calls to check_plain() in core to Drupal\Component\Utility\String::checkPlain() in core/modules/A-L but it could not be committed there due to the size of the patch - it needed to keep getting re-rolled as core changed.
Comment #3
longwaveComment #4
thedavidmeister commentedseems fine.
Comment #5
catchCommitted/pushed to 8.x, thanks!