There is a call to check_plain() in:

- core/modules/block/lib/Drupal/block/BlockViewBuilder.php

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

divesh.kumar’s picture

Status: Active » Needs review
FileSize
863 bytes

Patch is attached.

thedavidmeister’s picture

Status: Needs review » Needs work

Thanks @divesh, we actually use a slightly different format to simplify things with namespace aliases so we can just write String::checkPlain() (without the extended prefix). I added instructions to the parent issue just now, that should hopefully make things clearer.

The code we want here is actually taking part of the patch at #2089465: Convert all calls to check_plain() in core to Drupal\Component\Utility\String::checkPlain() in core/modules/A-L but it could not be committed there due to the size of the patch - it needed to keep getting re-rolled as core changed.

longwave’s picture

Status: Needs work » Needs review
FileSize
1.03 KB
thedavidmeister’s picture

Status: Needs review » Reviewed & tested by the community

seems fine.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.