Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
core/modules is large, so splitting roughly in half, A-L and M-Z. This is A-L. M-Z is #2089471: Convert all calls to check_plain() in core to Drupal\Component\Utility\String::checkPlain() in core/modules/M-Z (except system/simpletest).
Part of #2089331: [meta] Replace calls to check_plain() with Drupal\Component\Utility\String::checkPlain().
Comment | File | Size | Author |
---|---|---|---|
#31 | check_plain_to_String_checkPlain-2089465-31.patch | 68.33 KB | InternetDevels |
Comments
Comment #1
thedavidmeister CreditAttribution: thedavidmeister commentedComment #2
thedavidmeister CreditAttribution: thedavidmeister commentedComment #4
thedavidmeister CreditAttribution: thedavidmeister commentedComment #6
thedavidmeister CreditAttribution: thedavidmeister commentedComment #8
thedavidmeister CreditAttribution: thedavidmeister commentedComment #10
sidharthapI tried the patch on D8 fresh installation but it is get failed.
Comment #11
sandipmkhairnar CreditAttribution: sandipmkhairnar commentedComment #12
mcrittenden CreditAttribution: mcrittenden commentedComment #14
thedavidmeister CreditAttribution: thedavidmeister commented#11 is missing lots of
use Drupal\Component\Utility\String;
lines and is less than half the size of #8. I'm going to re-roll #8.Comment #15
thedavidmeister CreditAttribution: thedavidmeister commentedreroll
Comment #17
rpsuFound one more check_plain, which is now also replaced.
Comment #19
rpsu#17: check_plain_to_String_checkPlain-2089465-17.patch queued for re-testing.
Comment #21
rpsuThis patch makes Path tests to fail, but I don't seem to find where tested path alias is or should be set? Locally that test passes, though.
Comment #22
rpsuComment #24
netsensei CreditAttribution: netsensei commentedHm. Patch doesn't apply to HEAD anymore.
Comment #25
netsensei CreditAttribution: netsensei commentedChasing HEAD + Fixed the problem with forum tests failing: another missing
use Drupal\Component\Utility\String
in forum.moduleLet's see...
Comment #26
netsensei CreditAttribution: netsensei commentedHm. Forgot to set status.
Comment #26.0
netsensei CreditAttribution: netsensei commentedUpdated issue summary.
Comment #27
areke CreditAttribution: areke commentedAnd this doesn't apply anymore... It seems that we're going to have to continue chasing HEAD, since this affects so many files.
Comment #28
sunComment #29
chr.fritschComment #31
InternetDevels CreditAttribution: InternetDevels commentedComment #32
InternetDevels CreditAttribution: InternetDevels commentedComment #34
thedavidmeister CreditAttribution: thedavidmeister commented#2196797: Convert all calls to check_plain() in core to Drupal\Component\Utility\String::checkPlain() in action module
Comment #35
thedavidmeister CreditAttribution: thedavidmeister commentedI'm going to close this as a duplicate. Please see the parent issue for smaller issues that are more committable.
Thanks to everyone for their hard work re-rolling this over and over, I hope to see you all in the mini issues!