Closed (fixed)
Project:
Panels
Version:
7.x-3.4
Component:
Mini panels
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Feb 2014 at 09:02 UTC
Updated:
24 Nov 2014 at 09:28 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
aasarava commentedConfirmed that this is happening. For me, it seems to happen on pages that use Views that have block displays instead of pane displays.
The exact use case is needing a Views block to be added to a specific position in content via Display Suite block fields, and then Panels is used on top of that to add other panes around the rendered content.
Comment #2
deanflory commentedI too am getting this error but I've only noticed it showing up when running cron manually and ending up on the Status repot page:
Comment #3
deanflory commentedCould this be due to an upgrade in PHP to 5.4 where things are more strict?
I also get this on the Available Updates page.
Comment #4
loziju commentedI confirm that I see the same issue. As for the cause, I can't really pinpoint yet, but I have complex layout as mentioned in #1.
Relevant modules installed on my setup are:
panels-7.x-3.4
ctools-7.x-1.4
views-7.x-3.7+23-dev
@deanflory, I use PHP 5.3.14 and still seeing this issue. To me this is just a matter of missing parameter bid in some instances of mini panels.
As I need some commits in panels-7.x-3.4, I just come up with very simple quick workaround, i.e. to check if bid exists. I think properly fixing this should require more effort, but I hope this is sufficient and not disrupting other functionalities for now (except for missing the contextual links).
Comment #5
scjv commentedComment #6
loziju commentedErmm @scjv not sure why you change the status to fixed. Changing this to needs review.
Comment #7
japerryActually this looks pretty good. We're acting on a views alter, and there is probably a chance that a view won't contain a bid. Fixed!
http://drupalcode.org/project/panels.git/commit/a267233
Comment #9
Clint Eagar commentedpatch also worked for me
Comment #11
monaw commentedCan we simplify the check fix from:
if (isset($element['#element']['#block']) && isset($element['#element']['#block']->bid) && strpos((string) $element['#element']['#block']->bid, 'panels_mini') === 0) {
to:
if (isset($element['#element']['#block']->bid) && strpos((string) $element['#element']['#block']->bid, 'panels_mini') === 0) {
since in the first form the second isset should cover the first right?
Comment #12
kopeboyHow can this be fixed? I have this version and I'm still seeing this error
Comment #13
kopeboyComment #14
kopeboyI am having this messages on Panel pages where I place Menus with Style: System block.
Panels is missing block id (bid), but I can find the menus I've placed at admin/structure/blocks so they should have a block id even if they are placed in any region from there.
Comment #15
jkingsnorth commentedThe committed patch fixes the issue for me.
Comment #16
jkingsnorth commentedThis is fixed in the latest dev so let's set the issue status back.
If anyone wants to improve on it then it would be best to open a new issue =]