Add a dedicated @Constraint annotation class

Marked #2226813: Create a specific Plugin annotation for Drupal Constraint plugins as a duplicate of this issue.

Hmm, so we don't need a use for the annotation class?

The annotation class has + public $types;

The annotations themselves have type

Hmm, so we don't need a use for the annotation class?

No you don't, we have some magic to load these automatically.

actual tag has no dash.

Rerolled

i am working on that issue

Rerolled Patch

Change Comment Number

patch in #4 was 12k bytes.
patch in #12 was 909 bytes. Seems like the rerolls here have done something not correct.

Also #20 looks to be the same as #17... you dont need to post a patch again to retest a previous patch, just use the retest link.
And if you think a previous patch was wrong, please add a comment saying why.

It would really help if when posting a reroll if people who say which patch they were rerolling. was everyone trying to reroll #4?

Also, was anyone able to install drupal after their reroll locally?

View the testbot results,
seems the error is
Recoverable fatal error: Argument 3 passed to Drupal\Core\Plugin\DefaultPluginManager::__construct() must implement interface Drupal\Core\Extension\ModuleHandlerInterface, string given, called in /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Validation/ConstraintManager.php on line 48 and defined in Drupal\Core\Plugin\DefaultPluginManager->__construct() (line 99 of /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Plugin/DefaultPluginManager.php).

yes, this moves over some docs but needs to remove previous docs.

ok, re-rolled the patch and fixed some errors:
- Constraint class: it's 'type' not types and fixed its docs
- removed referenced to not existing hook docs for altering
- added pointer to the constraint annotation from the manager
- fixed instantation using the constraint and rely for it to set default values
- converted not yet converted constraint plugins

There is actually a hook

$this->alterInfo('validation_constraint');

Also added some other stuff we typically add in annotations

yes, there is hook - but no docs for it. Thus, if you add an @see, also add docs for the hook.

added the hook and some forgotten constraints

one more

Postponing for the moment on #1966246-28: [meta] Introduce specific annotations for each plugin type; we can reactivate this issue once we have a decision there. Thanks!

Unpostponing following the discussion on #1966246: [meta] Introduce specific annotations for each plugin type; we can go ahead with this issue during 8.0.x. Thanks!

Oh, we probably need to update a change record though (or add one if it doesn't already exist). We can use the same change record for this and the other child issues.

Re-roll.

Only nitpicks. The executable code looks good.

1. +++ b/core/lib/Drupal/Core/Validation/Annotation/Constraint.php
   @@ -0,0 +1,59 @@
   + * Defines a validation constraint annotation object.
   

   Any class defines an object, really. This feels redundant and confusing. No real problem here, though.

2. +++ b/core/lib/Drupal/Core/Validation/Annotation/Constraint.php
   @@ -0,0 +1,59 @@
   + * For a working example, see \Drupal\Core\Validation\Plugin\Validation\Constraint\LengthConstraint
   

   80-character limit.

3. +++ b/core/lib/Drupal/Core/Validation/Annotation/Constraint.php
   @@ -0,0 +1,59 @@
   +   * The plugin ID usually resembles the class name without the "Constraint"
   +   * suffix.
   

   We shouldn't advise people on what to call their plugins, especially because the only requirement is that plugin IDs are prefixed.

4. +++ b/core/lib/Drupal/Core/Validation/Annotation/Constraint.php
   @@ -0,0 +1,59 @@
   +   * @var \Drupal\Core\Annotation\Translation
   

   Should be @var string|\Drupal\ore\Annotation\Translation, because plain strings are allowed as well.

5. +++ b/core/lib/Drupal/Core/Validation/Annotation/Constraint.php
   @@ -0,0 +1,59 @@
   +   * An array of data type IDs for which this constraint applies. Valid values
   

   Can we say plugin IDs just to be a little more specific as to what kind of IDs we mean?

6. +++ b/core/lib/Drupal/Core/Validation/Annotation/Constraint.php
   @@ -0,0 +1,59 @@
   +  public $type = array();
   

   Let's be progressive and use the short array syntax ([]) here.

Thanks! Nice work. I don't think there's anything that would block an RTBC at this point.

+++ b/core/lib/Drupal/Core/Validation/Annotation/Constraint.php
@@ -40,20 +38,20 @@ class Constraint extends Plugin {
+   * An array of DataType plugin IDs for which this constraint applies. Valid

Why the capitalization?

Yay the last of the non test plugins fixed - nice work. Committed 3b62b84 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.