with entity reference 7.x-1.1 the remove button appears but when clicked the ajax wheel spins but the request doesn't remove the value. Tried it multiple times on different installations with same results. Does it work for others? Thanks.

CommentFileSizeAuthor
#4 multiple_fields_remove_button-entity_error-2191731-4.patch3.01 KBantiorario
#3 multiple_fields_remove_button-entity_error-2191731-3.patch2.93 KBalex.skrypnyk
#1 multiple_fields_remove_button-entity_error-2191731-1-D7.patch868 bytestatewaky

Comments

tatewaky’s picture

tatewaky commented
StatusFileSize
new multiple_fields_remove_button-entity_error-2191731-1-D7.patch868 bytes

Hi,

i ran out with the same issue, it turns that entities split it in other level on the array, this way:

http://i.imgur.com/b5YmVZT.png

i am attaching a patch that fix that issue, hopefully will be on the next version of the module.

Anonymous’s picture

Anonymous (not verified) commented

Hey,

Thanks for the patch, applied the patch but am still having issues.

I've got four multipleER fields in the same page.
It works on some entity reference fields and not on others.
It works sometimes but fails most of the time.

alex.skrypnyk’s picture

alex.skrypnyk
he/him
Primary language English
Location Melbourne
commented
Title: doesn't work on entity reference fields » Doesn't work on entity reference fields
Status: Active » Needs review
StatusFileSize
new multiple_fields_remove_button-entity_error-2191731-3.patch2.93 KB

tatewaky is right. Entity reference field requires deeper drilling down through $element array.

Attached patch solves this by explicitly handling entityreference field type - the change only reads values 1 array deeper .
The problem was related to the fact that remove button name atrribute was constructed incorrectly as none of the parents, including the field itself, were properly read from $element array. This made the button submit for incorrect fields and even incorrect values of the same field.

The patch also reorders how widget alter hook is applied to avoid triggering on all widgets - performance improvement.

antiorario’s picture

antiorario commented
Version: 7.x-1.3 » 7.x-1.x-dev
StatusFileSize
new multiple_fields_remove_button-entity_error-2191731-4.patch3.01 KB

The patch above failed. I recreated one with some cleanup.

jimmyko’s picture

jimmyko commented
Status: Needs review » Reviewed & tested by the community

@antiorario

It is working! Thanks

paean99’s picture

paean99 commented

#4 seems to be working for me.
Thanks.

geerlingguy’s picture

geerlingguy commented

Another RTBC here—before applying patch, only the first element was being removed on a multi-value entityreference_autocomplete field (even though UI showed otherwise). After applying patch, the correct field was removed when saving the node.

This patch fixes this issue, plus #2457573: Remove button not working properly on entity reference, which I've marked as a duplicate. Applies cleanly to 7.x-1.x dev branch, please commit if possible!

martin_q’s picture

martin_q
Primary language English
Location Leipzig, Germany | Manchester, UK
commented

Also confirm that #4 patch works for me; and I was able to add a further patch for Scald atom reference using the same principle, and that worked great too.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented

RTBC++

  • 5556758 committed on 7.x-1.x 
    Issue #2191731  by antiorario, geerlingguy, mxr576:Doesn't work on...
asghar’s picture

asghar commented

Thanks to all. I have implemented the patch and will release new version.

asghar’s picture

asghar commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

martichka5’s picture

martichka5 commented

Hello,

Thank you for the module and its functionality.

I have encountered a problem with all field types allowed to the module. In our case we use multiple entityreference field. The problem is that when we remove some value and then without saving the whole node we click "Add another Item" the last row value is added no matter which value we have removed. Is this a normal behaviour? We need when clicking on "Add another Item" to get empty field.

Any help is appreciated.
Thank you in advance!

martin_q’s picture

martin_q
Primary language English
Location Leipzig, Germany | Manchester, UK
commented

Hi martichka5,

You've added a comment to an issue that is already marked closed. It looks to me that you are describing a new and separate problem, so it wouldn't be appropriate to re-open this issue for that. It sounds like you've found a legitimate bug, though, and I'd encourage you to open a new issue, which will then have a good chance of being seen and addressed. :)

martichka5’s picture

martichka5 commented

Thank you @martin_q!

I will open a new issue.

mrpauldriver’s picture

mrpauldriver commented

Be good to see this committed to a 7.x-1.6 release