Adsense ads do not display on secure web pages using this module. See

https://support.google.com/adsense/answer/10528?hl=en

on how to modify the code to support this feature.

CommentFileSizeAuthor
#4 ssl4Watermark-2190597-2.patch594 bytespmagunia
#2 ssl4Watermark-2190597-2.patch595 bytespmagunia
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jcnventura’s picture

jcnventura CreditAttribution: jcnventura commented
Status: Active » Fixed

Just added it to git.

http://drupalcode.org/project/adsense.git/commit/e640410

pmagunia’s picture

pmagunia
Primary language English
Location Philadelphia 🇺🇸
CreditAttribution: pmagunia commented
Version: 7.x-1.1 » 7.x-1.2
Status: Fixed » Needs review
FileSize
ssl4Watermark-2190597-2.patch595 bytes

EDIT: please ignore this patch. the patch to review is in comment #4. sorry for the mixup

When loading the JS watermark, SSL pages complain about insecure content on the page.

I traced it to the watermark GIF which is a hard-coded http request.

This patch changes the http: to //.

pmagunia’s picture

pmagunia
Primary language English
Location Philadelphia 🇺🇸
CreditAttribution: pmagunia commented

please ignore this patch

pmagunia’s picture

pmagunia
Primary language English
Location Philadelphia 🇺🇸
CreditAttribution: pmagunia commented
FileSize
ssl4Watermark-2190597-2.patch594 bytes

this is the patch to review. Sorry for mixup.

pmagunia’s picture

pmagunia
Primary language English
Location Philadelphia 🇺🇸
CreditAttribution: pmagunia commented

please ignore this patch.

  • jcnventura committed dd3bd4f on 7.x-1.x 
    Issue #2190597 by Tetragy: SSL pages complain when loading the watermark...

  • jcnventura committed 575f6af on 
    Issue #2190597 by Tetragy: SSL pages complain when loading the watermark...
jcnventura’s picture

jcnventura CreditAttribution: jcnventura commented
Status: Needs review » Fixed

Thanks for the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.