It would be pretty cool to be able to use breakpoint panels whitout using the panels ipe renderer. Since the settings are stored independent from ipe this should be no problem. In panels 3.x is a hook which allows us to add links to the pane settings link list. The patch uses this to make the settings available in default panels ui.

Comments

hydra’s picture

Status: Active » Needs review
hydra’s picture

StatusFileSize
new743 bytes
steffenr’s picture

Hi @Hydra - i just had a look at your patch - looks fine for me and well documented.

SteffenR

hydra’s picture

StatusFileSize
new754 bytes

Fixed the settings arry, to not override the default stlye settings key.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

This worked fine for me as well, and it looks like a reasonable approach, even we want to have something more ctools/panels-native on the longrun probably.

dawehner’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new1009 bytes
new412 bytes

These are the lines which page_manager use for its hook_menu() entries, 'theme callback' allows you to inherit the used theme of the "parent" page theme
independent from the path.

$items = array();
  $base = array(
    'access arguments' => array('use page manager'),
    'file' => 'page_manager.admin.inc',
    'theme callback' => 'ajax_base_page_theme',
  );
hydra’s picture

Status: Needs review » Reviewed & tested by the community

This is just awesome, thx dawehner, I had no clue how to fix this one, so I just lived with it.

mvdve’s picture

Tested patch #6 and works like a charm. Please commit.

svajlenka’s picture

Status: Reviewed & tested by the community » Needs work

I tested the patch provided in #6 and while it did add breakpoint settings links to all the pane context links. However, because it does not check for the existence of $pane->did, when you click `breakpoint settings` on a pane that is stored in code, an error is generated while displaying the breakpoint settings form.

svajlenka’s picture

Status: Needs work » Needs review
StatusFileSize
new1.92 KB

Wrapped breakpoint_panels_get_pane_links_alter in check for $pane->did to address the issue encountered in #9

svajlenka’s picture

svajlenka’s picture

Please disregard the patch I posted above. I've corrected this issue with this more comprehensive patch: https://drupal.org/comment/8580927#comment-8580927

svajlenka’s picture

Status: Needs review » Closed (fixed)

Yay I'm a co-maintainer now! I've committed the patch in #6.