Invalid cache on restoring cache controller settings

Changing the call in testBranchOffAndDelete() from

$branches = $this->repo->loadBranches();

to

$branches = $this->repo->loadBranches(array(), array(), array('may cache' => FALSE));

Makes the test succeed, so I think that confirms it is a caching issue.

A call to $this->repository->loadBranches() in VersioncontrolGitRepositoryHistorySynchronizerDefault::syncEvent() after the enhancements branch is deleted does correctly show only newbranch remaining.

Maybe it is possible the tests somehow have a different repository object.

I confirmed the test and VersioncontrolGitRepositoryHistorySynchronizerDefault::syncEvent() have the same repository object. So, enhancements somehow gets added back by the time the test checks it.

The cached repo comes back with

$this->getBackend()->restoreControllerCachingDefaults();

in VersioncontrolRepository::syncEvent(). So, when disableControllerCaching() becomes active, the cache should still be able to be invalidated.

This patch resets the cache when restoreControllerCachingDefaults() is called. I think it is best to clear it all since anything could have changed while caching is off.

(correct patch)

Deployed to Drupal.org.