Closed (fixed)
Project:
Bootstrap
Version:
7.x-3.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Jan 2014 at 14:28 UTC
Updated:
29 Mar 2015 at 12:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
rjacobs commentedAs best I can tell the CSS for that unpublished background color is actually provided by core in
modules/node/node.css:The trick is that bootstrap manually excludes
modules/node/node.cssfrom being added (see the "exclude" lines in bootstrap.info) and does not provide its own styling for the "node-unpublished" class. I'm not sure if that was by design or not, someone else would need to speak to that.Of course you could add-back the CSS above in your sub-theme in the meantime.
Comment #2
markhalliwellI've noticed this bug too over time, but keep forgetting to do anything about it.
AFAIK, this was just an oversight and not intentional. I inherited the excluded CSS files from core and haven't really paid too much attention to them.
I went ahead and took a look at
modules/node/node.cssand it appears to just contain the following:I'm ok with just un-excluding this file entirely, I don't see why it ever was in the first place :-/
Comment #3
rjacobs commentedYeah, the stuff in node.css seems pretty innocuous. My only guess would be that somewhere along the line someone figured they would implement better styles in bootstrap directly for this, and wanted to turn off (what would become) conflicting rules from core? Whatever the case, without an alternative implementation, sticking to what core is doing probably makes sense.
I've attached patch. Note that I didn't remove the whole exclude line, but rather just commented it out as per what appears to be a style for that info file (I'm guessing someone is tracking something by leaving commented-out exclusions in there). One character patches are always rewarding.
Also, it looks like they are trying to handle this better in D8 core - #867830: "Unpublished" style of rendered entities is not accessible (and looks bad). After that's settled maybe it could be inspiration for a "better" bootstrap-specific solution in D7. That would probably be another issue though.
Comment #5
markhalliwell