Uninstall system does not correctly remove dynamic menu items when a module is deleted [#217803]

The uninstall system currently uninstall the module, then pulls and removes the menu items. This works fine in situations where the menu system is static, however, in situations where the menu system is dictated via a database query (such as in views), invoking the database uninstall before pulling the menu causes errors to be thrown and menu items to not be correctly cleared from the system. By simply reversing the logic (first, pull the menu, then uninstall the module), things behave correctly and all menu items are correctly deleted.

Comment	File	Size	Author
#4	uninstall-logic-reversal_0.patch	973 bytes	Senpai
#4
	uninstall-logic-reversal.patch	813 bytes	csevb10

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

pwolanin CreditAttribution: pwolanin commented 7 February 2008 at 03:04

patch code looks good, applies cleanly

Comment #2

pwolanin CreditAttribution: pwolanin commented 10 February 2008 at 19:21

Status:

Needs review

» Reviewed & tested by the community

tested with poll module, and uninstall works fine with this change (no logical reason why it wouldn't).

Comment #3

chx CreditAttribution: chx commented 10 February 2008 at 20:31

Yes this is a fine change.

Comment #4

Senpai CreditAttribution: Senpai commented 11 February 2008 at 00:53

Title:

Uninstall system

» Uninstall system does not correctly remove dynamic menu items when a module is deleted

File	Size
uninstall-logic-reversal_0.patch	973 bytes

Tested against HEAD using Devel and Devel Generate. All install/uninstall features still work as intended. I added a couple of one-liner comments to help out anyone staring at this function in the future. Send this baby on down the road!