Updated: Comment #N

Problem/Motivation

#1890784: Refactor configuration import and sync functions introduced the event 'config.installer.validate' also both dispatcher and listener. In #2095489: Separate out module install config code from import code the event dispatcher has been removed (ConfigInstaller.php file was removed) and it did not return with #2166065: Replace config_install_default_config with ConfigInstaller service.

Proposed resolution

Remove the event lister 'config.installer.validate'.

Remaining tasks

Get confirmation that the event dispatchers are no longer required.
Make the patch.

User interface changes

none

API changes

none

CommentFileSizeAuthor
#4 config-remove-event-listeners-2177689-4.patch649 bytessutharsan
#1 config-remove-event-listeners-2177689-1.patch3.54 KBsutharsan

Comments

sutharsan’s picture

sutharsan commented
Status: Active » Needs review
StatusFileSize
new config-remove-event-listeners-2177689-1.patch3.54 KB

No confirmation yet if the events are really deprecated, but let's see what this patch does.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

#2172561: Config overrides may spill over to undesired places also removes the global override subscriber (and is RTBC). That is indeed left around and ConfigFactory now does all that directly. I'm not at all sure about the config import subscriber though :/ Settings needs work since the global removal is duplicate.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented 
+++ /dev/null
@@ -1,48 +0,0 @@
-class ConfigImportSubscriber implements EventSubscriberInterface {
...
-    $events['config.importer.validate'][] = array('onConfigImporterValidate', 40);
-    $events['config.installer.validate'][] = array('onConfigImporterValidate', 40);

This should be left in as the config.importer.validate event still fires. However the config.installer.validate does not occur anymore.

sutharsan’s picture

sutharsan commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new config-remove-event-listeners-2177689-4.patch649 bytes

So the only event handler to remove is 'config.installer.validate'.
No interdiff as the remaining patch is minimal now.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Configuration system

#2172561: Config overrides may spill over to undesired places will remove the global override listener (unused). Alex Pott confirmed about the updated patch is fine. So let's do this.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 93206c3 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.