Separate out module install config code from import code

Then you can straight up remove the ConfigInstaller class

New patch which removes the ConfigInstaller class and should hopefully fix the broken test in ConfigInstallTest.

I also added another line to reset the static cache (via the ConfigFactory) for the config name being imported in config_install_default_config() as other tests were failing and it seemed like this was because it was retrieving stale config items from there.

+++ b/core/includes/config.inc
@@ -66,20 +63,34 @@ function ($value) use ($name) {
+    $entity_manager = Drupal::service('entity.manager');
+    $config_factory = Drupal::service('config.factory');
+    $context = new FreeConfigContext(Drupal::service('event_dispatcher'), Drupal::service('uuid'));
+    $target_storage = Drupal::service('config.storage');

We need to call the ConfigFactory->enterContext before we do anything with config and we need to call ConfigFactory->leaveContext

New patch attached which switches in and out of context around the config saving.

Wrong interdiff uploaded but the patch is still good - so ignore the interdiff in #12

#12: 2095489-12.patch queued for re-testing.

Finally got a pass let's get this done

Committed/pushed to 8.x, thanks!

So this is fixed then I guess :)