Comments

lolandese’s picture

Status: Active » Needs review
StatusFileSize
new22.78 KB
new108.84 KB
new10.04 KB

Attached patch:

  • adds license info optionally both to the caption and/or info when enlarging an image (Colorbox/Lightbox)
  • checkboxes are added on the Flickr configuration page to set preferences
  • uses CC icons with a link to the corresponding Creative Commons human friendly info page (see image)
  • uses a longer description as the ending info element when enlarging an image (see image, Lightbox)
  • takes care of creating an extra index key on the used variable on install to avoid 'undefined index' errors
  • does not include Flickr Field.

CC icons
In Lightbox

Credit:
Débordement de l'Aven à Pont-Aven by Ronan Davalan.

lolandese’s picture

Add:

span.flickr-cc {
margin-bottom: 5px;
}

to avoid the icons sticking to the elements below it.

lolandese’s picture

Wrap translatable strings in t() function.

lolandese’s picture

StatusFileSize
new10.21 KB

Integrated suggestions of comment #2 and #3.

lolandese’s picture

lolandese’s picture

Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)
lolandese’s picture

Some info about the right way of attribution at: https://www.flickr.com/services/developer/attributions/

lolandese’s picture

Status: Patch (to be ported) » Closed (won't fix)
lolandese’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Closed (won't fix) » Closed (fixed)

Setting this back to D7 and being 'fixed (closed)'.

Main reason is the fact that links to this issue show the status on hover without revealing the version (6 or 7). This might give the impression that the mentioned issue will not be solved, while in fact it is already fixed for the D7 version. 'Fixed (closed)' reflects the current status correctly for D7. 'Closed (won't fix)' is only valid for the minimally maintained D6 version of the module.