Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.We already implemented this for contextual links in #1971108: Convert contextual.js to use Backbone (and support dynamic contextual links). We've seen zero complaints about the implementation there so far.
We should also implement it for the Toolbar. It's a trivial patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | toolbar_touch_support-2175637-11.patch | 1.46 KB | Wim Leers |
Comments
Comment #1
Wim LeersComment #2
Wim LeersNow there's also an issue to backport this to the D7 backport of D8's Toolbar: #2175639: Touch support for the navbar: greatly improves the UX of Navbar on mobile devices.
Comment #3
Sam152 CreditAttribution: Sam152 commentedI have spooled this patch up in Safari on an iPad 4 running iOS6. Works as advertised, however when I hold down the menu items the event is fired twice, opening and then closing the menu in quick succession. I would hazard a guess that the click and touchend events are both being fired.
Can anyone else confirm this?
Going to set this to needs work, however if this issue is not covered by the scope of this patch feel free to set it back to needs review.
Comment #4
Wim Leers#3: can you please check whether you can reproduce that problem with contextual links in general and the pencil icon in the toolbar in specific also? (Because if you experience this problem with the proposed patch, you should also be able to reproduce it there. If not, then something else is at play.)
Comment #5
Sam152 CreditAttribution: Sam152 commentedSo I spooled the patch back up and tested with an iPad 4 running iOS 6. I also spooled up a copy of 8.x without the patch.
The problem existed and was replicable on the version with #1 applied. The pencil icon was also not clickable whatsoever. Neither of these issues seemed to happen on the plain 8.x version.
Here is a quick video I took testing the two patches, apologies for the bad quality: https://www.youtube.com/watch?v=GMKzykNzIDg
Comment #6
nod_can we haz that for tabledrag as well? it's broken on touch-enabled laptop: #2177293: Drag and drop broken on touch enabled laptops
Comment #7
LewisNyman1: toolbar_touch_support-2175637-1.patch queued for re-testing.
Comment #9
Wim LeersStraight reroll. Was broken by the massive JS reindentation patch.
Comment #10
hass CreditAttribution: hass commentedThere is an indendation bug...
Comment #11
Wim LeersHAH! Stupid! Thanks for catching that :) Pretty awful indentation bug even! This one should be good.
Comment #12
LewisNymanComment #13
LewisNymanComment #14
Wim LeersWow, blast from the past. What's holding this back?
Comment #15
LoMo CreditAttribution: LoMo commentedI've tested this on simplytest.me with Android and the Samsung Galaxy Note 2 (GT-N7105 running Android 4.3) and the toolbar seems pretty sweet. I don't notice any delay.
Comment #16
LoMo CreditAttribution: LoMo commentedLooking good, setting to RTBC.
Comment #17
LewisNymanI just tested it on my iPhone and it's much better :) RTBC++
Comment #18
alexpottCommitted c70170c and pushed to 8.0.x. Thanks!