Entity displays are themselves config entities

Don't see anything wrong with this

+1 from me

Committed and pushed to 8.x. Thanks!

Hm, #2031725: Move all entity display interfaces to the core component did explicitly remove this with a lot of discussions around this.

Oh, thanks. Was not aware.

Rolled back for now, pending further discussion.

Not sure if it was necessary, I commented over there to point the involved people to this issue

You don't necessarily have to be a configEntity to do the job of an EntityDisplay ("host display settings for the components of an entity")

Why do we want to mock an EntityDisplayInterface rather than an EntityDisplay or an EntityFormDisplay specifically ?

@yched: The thing is that we need a single interface to type hint in e.g. entity crud hooks, where we want both the ConfigEntityInterface methods and those of EntityDisplay.

The only thing that could work is having both this interface and one for the entity, that extends from this and ConfigEntityInterface, but that also seems fairly complicated.

1: 2175517_1.patch queued for re-testing.

New patch.

Here's why I think this makes sense:

Code from EmailFieldTest, but any other snippet is just the same:

    entity_get_display('entity_test', 'entity_test', 'full')
      ->setComponent($field_name, array(
        'type' => 'email_mailto',
      ))
      ->save();

PhpStorm analysis: "Method 'save' not found in class \Drupal\Core\Entity\Display\EntityDisplayInterface".

14: 2175517_14.patch queued for re-testing.

14: 2175517_14.patch queued for re-testing.

Back to RTBC, it was just the test bot playing up.

14: 2175517_14.patch queued for re-testing.

Aw testbot...

hm, that was changed by purpose to be decoupled, but #15 and the entity_get_display() documentation provide good reasons to re-introduce the coupling - thus agreed.

Committed/pushed to 8.x, thanks!

Patch in #14 was never committed. Here is the patch for the latest HEAD.

Weird, but +1 to the latest patch.

Committed and pushed to 8.x. For real this time. :)