Like the title says...

CommentFileSizeAuthor
#12 Triggers-Typo-Corrected-2165143-12.patch625 bytesnathanc
#12 node.test_after.png21.17 KBnathanc
#12 node.test_before.png29.43 KBnathanc
#8 tigger-typo-2165143-8.patch625 bytesSidneyGijzen
#1 tests-typo-2165143-1.patch1.62 KBDavid_Rothstein

Comments

David_Rothstein’s picture

David_Rothstein commented
Component: other » documentation
Status: Active » Reviewed & tested by the community
Issue tags: +Needs backport to D7
StatusFileSize
new tests-typo-2165143-1.patch1.62 KB

Clearly RTBC unless the tests fail for some reason.

I noticed this while committing a backport of half of this to Drupal 7 recently, so the bug exists there too.

xjm’s picture

xjm
she/her
Primary language English
commented

Confirmed that there are no other tiggers in core (unfortunately for Winnie the Pooh fans). So yes, this is RTBC even though David RTBCed his own patch. ;)

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Oooh, I want tigger in core! I am reluctant to commit this, but I will next time I'm doing commits. :)

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Tigger has been removed from 8.x. Alas! (committed patch).

In 7.x, I'm seeing one Tigger:
modules/node/node.test: // node_test_node_insert() tiggers a save on insert if the title equals

mgifford’s picture

mgifford
he/him
Primary language English
commented

Where is the "Like" button? A few Tiggers are way cooler than even a single Eeyore.

dcam’s picture

dcam commented
Issue tags: +Novice
mgifford’s picture

mgifford
he/him
Primary language English
commented

Think there's just this one, so super easy:

modules/node/node.test: // node_test_node_insert() tiggers a save on insert if the title equals

SidneyGijzen’s picture

SidneyGijzen commented
StatusFileSize
new tigger-typo-2165143-8.patch625 bytes

Fixed typo in node.test. See attached patch.

I hope I did everything right, since this is my first patch. All credits to mgifford's blogpost for drawing my attention to Drupal 7 issues and Drupal Ladder for teaching me how :)

SidneyGijzen’s picture

SidneyGijzen commented
Status: Patch (to be ported) » Needs review
Issue tags: -Needs backport to D7
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good, and I agree this is the only "tigger" spot in D7. Thanks!

SidneyGijzen’s picture

SidneyGijzen commented

You're welcome. Thanks for the fast feedback.

nathanc’s picture

nathanc commented
Status: Reviewed & tested by the community » Needs review
Issue tags: -Novice +Novice first_patch
StatusFileSize
new node.test_before.png29.43 KB
new node.test_after.png21.17 KB
new Triggers-Typo-Corrected-2165143-12.patch625 bytes

David, i see the issue already has a patch but i just saw a typo fix to be a good way to learn "how to patch drupal" and start giving back...

All kudos to drupalladder.org and @bdone

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

nathanc: If an issue already has a patch and has been set to "RTBC", please kindly find a different issue rather than duplicating the same patch. Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks again! Committed patch in #8 to 7.x.

  • Commit c32199c on 7.x by jhodgdon: 
    Issue #2165143 by MF82, mgifford: Fix tigger misspell in node.test

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

yesct’s picture

yesct commented
Issue tags: -Novice first_patch +Novice

I'm cleaning out tags that are little used. This one is only used here. Note the tag guidelines: Before adding tags read the issue tag guidelines. Do NOT use tags for adding random keywords or duplicating any other fields. Separate terms with a comma, not a space.