E.g convert a "." to an "underscore" only i.e for flickr.photos.getInfo use flickr_photos_getinfo().

The best moment to do this is when all current patches have been committed to avoid the necessity to reroll them because of changed function names.

Thanks.

CommentFileSizeAuthor
#5 2164839-5.patch24.78 KBrpayanm
#5 2164839-interdiff.txt321 bytesrpayanm
#4 2164839-4.patch24.58 KBrpayanm

Comments

lolandese’s picture

lolandese commented
Title: Implement a consistent naming for drupal wrapper functions around flick API methods » Consistent naming for wrapper functions around Flickr API methods
lolandese’s picture

lolandese commented
Issue tags: +Novice
lolandese’s picture

lolandese commented
Status: Postponed » Active
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new 2164839-4.patch24.58 KB
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
StatusFileSize
new 2164839-interdiff.txt321 bytes
new 2164839-5.patch24.78 KB

Removed a "TODO"

lolandese’s picture

lolandese commented
Status: Needs review » Reviewed & tested by the community
  • Patch applies cleanly.
  • Proposed naming convention is respected.
  • Sample check to see if instances are all replaced passes (old ones do not exist anywhere).

Improves maintainability and others understand the functions better in relation to the Flickr API. Even removing the 'TODO' code comments makes the job complete.

Great enhancement.

Thanks.

lolandese’s picture

lolandese commented
Status: Reviewed & tested by the community » Fixed

  • lolandese committed cde23e9 on 7.x-1.x authored by rpayanm 
    Issue #2164839 by rpayanm, lolandese: Consistent naming for wrapper...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.