Problem/Motivation

The template.php file has lots of inline code additions that should be moved to a separated file in order to be clean and easily maintainable.

Proposed resolution

  1. Move the prtfolio carousel code to a separated file called carousel.js
  2. Update drupal_add_js to call a file instead of adding an inline code.
  3. Fix Drupal JavaScript coding standards issues.

@see https://drupal.org/node/172169 and https://drupal.org/node/1720586

CommentFileSizeAuthor
#2 simplecorp-move_portfolio_carousel_to_saparated_file-2163083-1.patch8.46 KBrevagomes

Comments

revagomes’s picture

revagomes commented
Title: Move portfolio carousel code to its own file. » Move portfolio carousel code from template.php to its own file.
revagomes’s picture

revagomes commented
Issue summary: View changes
StatusFileSize
new simplecorp-move_portfolio_carousel_to_saparated_file-2163083-1.patch8.46 KB

Here goes the patch.

revagomes’s picture

revagomes commented
Issue summary: View changes
revagomes’s picture

revagomes commented
Status: Active » Needs review