This looks like a typo in menu_links_features_export_render() where this:

menu_link_save($temp = $link);

I think this should be:

menu_link_save($link);
CommentFileSizeAuthor
#3 features_strict-warning-menu-links_2155945-3.patch614 bytesidebr
#2 features_strict-warning-menu-links_2155945-2.patch590 bytesidebr

Comments

Anonymous’s picture

Anonymous (not verified) commented

Confirm same issue occurs for me when packaging menu and menu items in a features.

Strict warning: Only variables should be passed by reference in menu_links_features_export_render() (line 244 of /Users/XXXXXX/localhost/XXXXXX/sites/all/modules/contrib/features/includes/features.menu.inc).
Strict warning: Only variables should be passed by reference in menu_links_features_export_render() (line 244 of /Users/XXXXXX/localhost/XXXXXX/sites/all/modules/contrib/features/includes/features.menu.inc).
Strict warning: Only variables should be passed by reference in menu_links_features_export_render() (line 244 of /Users/XXXXXX/localhost/XXXXXX/sites/all/modules/contrib/features/includes/features.menu.inc).
Strict warning: Only variables should be passed by reference in menu_links_features_export_render() (line 244 of /Users/XXXXXX/localhost/XXXXXX/sites/all/modules/contrib/features/includes/features.menu.inc).
Strict warning: Only variables should be passed by reference in menu_links_features_export_render() (line 244 of /Users/XXXXXX/localhost/XXXXXX/sites/all/modules/contrib/features/includes/features.menu.inc).
Strict warning: Only variables should be passed by reference in menu_links_features_export_render() (line 244 of /Users/XXXXXX/localhost/XXXXXX/sites/all/modules/contrib/features/includes/features.menu.inc).
Strict warning: Only variables should be passed by reference in menu_links_features_export_render() (line 244 of /Users/XXXXXX/localhost/XXXXXX/sites/all/modules/contrib/features/includes/features.menu.inc).
Strict warning: Only variables should be passed by reference in menu_links_features_export_render() (line 244 of /Users/XXXXXX/localhost/XXXXXX/sites/all/modules/contrib/features/includes/features.menu.inc).
Strict warning: Only variables should be passed by reference in menu_links_features_export_render() (line 244 of /Users/XXXXXX/localhost/XXXXXX/sites/all/modules/contrib/features/includes/features.menu.inc).
Strict warning: Only variables should be passed by reference in menu_links_features_export_render() (line 244 of /Users/XXXXXX/localhost/XXXXXX/sites/all/modules/contrib/features/includes/features.menu.inc).
Strict warning: Only variables should be passed by reference in menu_links_features_export_render() (line 244 of /Users/XXXXXX/localhost/XXXXXX/sites/all/modules/contrib/features/includes/features.menu.inc).
idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new features_strict-warning-menu-links_2155945-2.patch590 bytes

I was able to reproduce the notice by exporting any menu link. Attached is a patch based on the solution presented in the issue summary. It's safe to remove the $temp assignment, since the variable is not used in the function. See my comment in #3

idebr’s picture

idebr commented
StatusFileSize
new features_strict-warning-menu-links_2155945-3.patch614 bytes

Actually menu_link_save takes an argument by reference, that is what the $temp assignment is for. Attached is a revised patch.

NaX’s picture

NaX commented
Status: Needs review » Reviewed & tested by the community

Agreed, I test the last patch and works as described.

ehijzen’s picture

ehijzen commented

Patch works as described

miromarchi’s picture

miromarchi commented

patch in #3 works for me as well. thanks

honza pobořil’s picture

honza pobořil commented
westwesterson’s picture

westwesterson commented

tested #3, works great.

manuelBS’s picture

manuelBS commented

patch #3 works for me as well. Thanks!

hefox’s picture

hefox commented
Status: Reviewed & tested by the community » Fixed

thanks

  • Commit ffb97cc on 7.x-2.x authored by idebr, committed by hefox: 
    Issue #2155945 by idebr: Strict warning: Only variables should be passed...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.