"No translatable fields" link points to misleading place. [#2154709]

Problem/Motivation

1. Enable content translation module.
2. Now you'll have a translate tab on an article you create. Although no configuration on articles to be translatable. And no fields are translatable. (This is being resolved in #2154701: Regression: Contextual links broken, tabs erroneously added after enabling content translation module).
3. The no fields translatable button leads to the field UI list page for the content type, where its pretty darn hard to configure each field one by one to be translatable. We have a nice all-in-one screen for that now. (To be resolved here).

Proposed resolution

The link should lead to a better place.

Remaining tasks

Do it.

User interface changes

Button goes to more useful place.

API changes

None.

Comment	File	Size	Author
#6	interdiff.txt	1.29 KB	gábor hojtsy
#6	content-translation-fields-6.patch	2.68 KB	gábor hojtsy
#4	content-translation-fields-4.patch	2.66 KB	gábor hojtsy
#4	interdiff.txt	912 bytes	gábor hojtsy
#1	content-translation-fields.patch	1.77 KB	gábor hojtsy
	Translate \| s081ffd522ea3f80.s3.simplytest.me 2013-12-11 18-18-24.png	69.83 KB	gábor hojtsy

Comments

Comment #1

gábor hojtsy

he/him

Hungarian

Hungary

commented 11 December 2013 at 17:30

Status	File	Size
new	content-translation-fields.patch	1.77 KB

Attached patch solves only problem 2 for now.

Comment #2

11 December 2013 at 20:15

Status:

Needs review

» Needs work

The last submitted patch, 1: content-translation-fields.patch, failed testing.

Comment #3

gábor hojtsy

he/him

Hungarian

Hungary

commented 12 December 2013 at 15:39

Title:	Translation tab appears when it should not; no fields link misleading	» No fields link points to misleading place
Issue summary:	View changes
Issue tags:		+Usability

Rescoped now that we found out tabs have the same bug that contextual links and are to be fixed in #2154701: Regression: Contextual links broken, tabs erroneously added after enabling content translation module then. Only the "no fields" link is in scope here.

Comment #4

gábor hojtsy

he/him

Hungarian

Hungary

commented 13 December 2013 at 13:52

Status:

Needs work

» Needs review

Status	File	Size
new	interdiff.txt	912 bytes
new	content-translation-fields-4.patch	2.66 KB

The overall page requires admin languages permission, so let's give that to the admin.

Comment #5

tim.plunkett

he/him

English

Philadelphia

commented 13 December 2013 at 18:07

Ah, this confused me greatly when I was manually testing in other issues, I'm glad it wasn't just me!

+++ b/core/modules/content_translation/content_translation.pages.inc
@@ -23,7 +23,7 @@ function content_translation_overview(EntityInterface $entity) {
+  $administrator = user_access('administer languages');

Might as well switch this to \Drupal::currentUser()->hasPermission('administer languages'); while you're here.

+++ b/core/modules/content_translation/content_translation.pages.inc
@@ -122,12 +122,8 @@ function content_translation_overview(EntityInterface $entity) {
+            $links['nofields'] = array('title' => t('No translatable fields'), 'href' => 'admin/config/regional/content-language', 'language' => $language);

Can we also switch this to use the route name?