This issue is about introducing the actual requirement. For the policy discussion about whether or not to make Drupal core require PHP 5.4, see #1498574: [policy, no patch] Require PHP 5.4

Bump Drupal core's PHP requirement to 5.4.2 as per #1498574: [policy, no patch] Require PHP 5.4.

Files: 
CommentFileSizeAuthor
#18 drupal8.php54.18.patch10.88 KBdmouse
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 64,710 pass(es).
[ View ]
#11 drupal8.php54.11.patch10.55 KBsun
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 64,721 pass(es).
[ View ]
#1 drupal_2152073_1.patch10.55 KBXano
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]

Comments

Xano’s picture

Assigned:Xano» Unassigned
Status:Active» Needs review
StatusFileSize
new10.55 KB
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]

This patch was made by cosmicdreams and me back in #1498574: [policy, no patch] Require PHP 5.4.

klonos’s picture

webchick’s picture

Note that I'm pretty sure this will continue to fail until we get 5.4.x testbots, which is blocked on #2135199: Provide php 5.4 testing on testbots for D8 code without breaking everything else. But at least now we can track it separately from various opinions on whether or not PHP 5.4 was a good idea. :) Thanks!

webchick’s picture

Category:Feature request» Task

This isn't a feature; this is from a policy discussion that's already been decided.

Status:Needs review» Needs work

The last submitted patch, 1: drupal_2152073_1.patch, failed testing.

webchick’s picture

Right. That. Ok, then...

jessebeach’s picture

Xano’s picture

There may be an issue with testing traits. See #2159845: Upgrade to PHPUnit 4.

andypost’s picture

Maybe 5.4.7?

sun’s picture

sun’s picture

Assigned:Unassigned» sun
Status:Postponed» Needs review
StatusFileSize
new10.55 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 64,721 pass(es).
[ View ]
Xano’s picture

Is there any difference between that patch and the one from #1?

Status:Needs review» Needs work

The last submitted patch, 11: drupal8.php54.11.patch, failed testing.

sun’s picture

Sorry, nope, that was just a safety re-roll to facilitate PHP 5.4 testbot testing.

We're re-testing HEAD right now, so as to double-check whether the failures in #11 are real (which would mean that the switch to PHP 5.4 uncovered some real test failures in HEAD).

sun’s picture

Berdir’s picture

Status:Needs work» Needs review

11: drupal8.php54.11.patch queued for re-testing.

sun’s picture

Assigned:sun» Unassigned
Status:Needs review» Reviewed & tested by the community
Issue tags:+PHP 5.4

Reviewed once more in depth, and all of the changes are awesomesauce.

To combat two potential questions/issues upfront:

  1. A debate of bumping to a later patch release than 5.4.2 should be moved to another issue. This patch gets us across the goal line and unblocks lots of happiness.
  2. There are probably many many more PHP 5.3 workarounds throughout the core code base in the meantime. Let's not hold up this patch on those, but tackle them in separate issue(s) instead.

Thanks!

dmouse’s picture

StatusFileSize
new10.88 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 64,710 pass(es).
[ View ]

We also can add the version in composer.json

Dries’s picture

Status:Reviewed & tested by the community» Fixed

I tried to commit this patch but it looks like core/lib/Drupal/Core/Mail/PhpMail.php was removed 8 hours ago. Looking at the patch, it seems like the PhpMail chunks can be removed safely, so I did exactly that. Committed to modified patch to 8.x. We may still have to delete death code from the new mailer class, if any.

webchick’s picture

Xano’s picture

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.