Problem/Motivation

This issue is postponed on #2152073: Bump Drupal core's PHP requirement to 5.4.2.

It is spun off from #2075185: When an entity is in-place edited (i.e. saved), other instances of that entity on the same page are not updated (no propagation).

A hack to support PHP 5.3 must be undone once PHP 5.4 is the minimum requirement for Drupal 8.

Proposed resolution

The solution to this issue is known and will be attached.

User interface changes

None.

API changes

None.

Original report by @jessebeach

CommentFileSizeAuthor
#2 unravel-edit-hack-2156793-2.patch2.29 KBwim leers
#1 unravel-edit-hack-2156793-1.patch2.75 KBjessebeach

Comments

jessebeach’s picture

jessebeach commented
Issue tags: +Spark
StatusFileSize
new unravel-edit-hack-2156793-1.patch2.75 KB

This patch unwinds the hack (as noted here: https://drupal.org/files/issues/interdiff_718.txt) put in place by Wim Leers in #2075185-11: When an entity is in-place edited (i.e. saved), other instances of that entity on the same page are not updated (no propagation).

I tested the patch on PHP 5.3.14 and it results in a PHP fatal error. After switching to PHP 5.4.4, the in-place editing works perfectly again.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Postponed » Needs review
Issue tags: +sprint
Parent issue: » #2075185: When an entity is in-place edited (i.e. saved), other instances of that entity on the same page are not updated (no propagation)
Related issues: +#2152073: Bump Drupal core's PHP requirement to 5.4.2
StatusFileSize
new unravel-edit-hack-2156793-2.patch2.29 KB

Drupal 8 requires PHP 5.4 as of last week, so we can now clean this up!

Patch didn't apply anymore; straight reroll.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Quick fix

Do we have a meta issue to track all of those issues?

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

@dawehner: not AFAIK.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: -sprint

Hurray for getting quick fixes in quickly! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.