Hi there.

We have next change record to Drupal core:
https://drupal.org/node/1918778

But Drupal\Core\Database\Log does not support this feature properly.
Drupal\Core\Database\Log::findCaller() method does not knows that database drivers can be located outside core.

For example I work to port Oracle Driver for D8 now, and I have next troubles:
1) Drupal\Core\Database\Log logs wrong data to database queries log.
2) every database driver that allocated not in core will fails on LoggingTest.

Proposed solution added in patch.

CommentFileSizeAuthor
#4 2151241_4.patch1.74 KBchx
drupal-fix_database_logger_works_with_not_core_drivers.patch893 bytesinternetdevels

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
Assigned: Unassigned » chx

Nice catch, original issue was commited without tests so we need chx here

andypost’s picture

andypost
he/him
Primary language Russian
commented
Parent issue: » #783812: Allow db drivers outside of 'core'
chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. I still have no idea how on earth would we test any of this.

chx’s picture

chx commented
Assigned: chx » Unassigned
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests
StatusFileSize
new 2151241_4.patch1.74 KB

In fact, after alexpott prodded me a little, I do know how to test this. This now can be phpunit'd by just instantiating the Log class and then passing a made up stack to the findCaller method (it's a pure function). Please do not forget to add doxygen for the new $stack argument.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
Issue tags: +PHPUnit

Added phpunit tag as per for #4. NR for testing the patch.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Needs work

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Closed (duplicate)

Fixed by
#2867788: Log::findCaller fails to report the correct caller function with non-core drivers.