Preview doesn't respect restricted view modes [#2149315]

If using the option to 'Restrict allowed view modes for Image', when inserting an image via wysiwyg the preview is using the view mode returned by variable_get('media_wysiwyg_wysiwyg_default_view_mode', 'full'), which might not be an available view mode if it has been restricted.

Comment	File	Size	Author
#5	media-preview-doesnt-respect-restricted-view-mode-2149315-5.patch	1.22 KB	David_Rothstein
#5
#1	media-preview-doesnt-respect-restricted-view-mode-2149315-1.patch	839 bytes	drasgardian
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

drasgardian CreditAttribution: drasgardian commented 3 December 2013 at 23:07

File	Size
media-preview-doesnt-respect-restricted-view-mode-2149315-1.patch	839 bytes

Comment #2

bneil CreditAttribution: bneil commented 4 December 2013 at 19:15

Component:

Code

» Media WYSIWYG View Mode

Comment #3

gmclelland CreditAttribution: gmclelland commented 13 December 2013 at 06:14

This worked for me. Thank you It prevents the media_wysiwyg_view_mode dialog from initially show a huge preview image. Instead it shows the a file icon with a link, which is the way it used to work.

The problem can be seen on simplytest.me with the https://drupal.org/project/media_dev
Simply embed an image using the wysiwyg on an article. In the dialog the image will be really big initially until you change the ajaxed view mode select dropdown.

Comment #4

gmclelland CreditAttribution: gmclelland commented 22 April 2014 at 17:30

Status:	Needs review	» Closed (duplicate)
Related issues:		+#2155931: Media Wysiwyg View Mode Preview Image doesn't remember the View Mode of the embedded media, +#2003810: When editing a file in the WYSIWYG, the "Display as" view mode selection does not inherit the default value

Closing as a duplicate of #2155931: Media Wysiwyg View Mode Preview Image doesn't remember the View Mode of the embedded media which is now marked as fixed. Please reopen if it is still an issue.

Comment #5

David_Rothstein CreditAttribution: David_Rothstein commented 13 May 2014 at 01:12

Status:

Closed (duplicate)

» Needs review

File	Size
media-preview-doesnt-respect-restricted-view-mode-2149315-5.patch	1.22 KB

That issue is about going back into the media dialog after the image has already been placed, but this is about initially inserting the image and is still reproducible.

Here's an updated patch, taking the changes that were committed in #2155931: Media Wysiwyg View Mode Preview Image doesn't remember the View Mode of the embedded media into account.