Closed (duplicate)
Project:
D7 Media
Version:
7.x-2.x-dev
Component:
Media WYSIWYG View Mode
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Sep 2013 at 14:17 UTC
Updated:
12 Aug 2015 at 21:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
goz commentedHere is the patch
This patch is part of the #1day1patch initiative.
Comment #2
reubenavery commented+1 for this. Thanks, GoZ.
Comment #3
mkhamash commentedThis patch does solve the issue of allowed view mode, I have made a new patch file against the latest dev bransh "7.x-2.0-alpha3+82-dev"
Comment #5
mkhamash commented1: media-mistake-between-restricted-and-allowed-view-mode-2092145-1.patch queued for re-testing.
Comment #7
letrotteur commentedFixed the issue for me. Thanks.
Comment #8
rooby commentedI can't reproduce this bug.
If I select all except the "WYSIWYG" view mode it works as expected.
The problem with this patch is that it reverses the way that the setting currently works which means it will break sites set up the current way (which is why the automated tests break for your patch above).
If this is your problem then the patch should focus on fixing this so that the entity is displayed properly instead of reversing the settings (even though I agree that the current setting is a bit confusing and it would be better the way your patch makes it).
Alternatively you would need to include extra changes in your patch to change the name of the variable and the user interface text to be allowed view modes and handle an upgrade path for existing settings.
As a side note a simpler way to achieve the logic in this patch would be to do something like this:
Comment #9
dave reidThis is a duplicate of #2479947: Switch to using an 'allowed view modes' logic instead of restricting view modes