Comments

balintbrews’s picture

Status: Needs work » Needs review
StatusFileSize
new1.25 KB

Simple patch that appends the submit button after the multipage buttons are in place.

balintbrews’s picture

Let's fix some whitespace issues in the patch.
Btw, it still applies with 1.4, too, and I still think it's a good idea to have this committed to the module. :)

The last submitted patch, 1: field_group-multipage-submit-position-2147445-1.patch, failed testing.

bverc’s picture

Priority: Minor » Normal
StatusFileSize
new1.22 KB

Agreed this should be done. Failed to apply against -dev. Rerolled against latest -dev. Still needs review.

Status: Needs review » Needs work

The last submitted patch, 4: field_group-multipage-submit-2147445-4.patch, failed testing.

bverc’s picture

Same as before except I've changed the multipage-button SPAN to a DIV and added form-actions class.

I changed the identifier of the submit buttons from .form-actions to #edit-actions

bverc’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: field_group-multipage-submit-2147445-6.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: field_group-multipage-submit-2147445-6.patch, failed testing.

bverc’s picture

Status: Needs work » Needs review
StatusFileSize
new1.66 KB

Alright, another attempt.

Status: Needs review » Needs work

The last submitted patch, 11: field_group-multipage-submit-2147445-11.patch, failed testing.

bverc’s picture

Status: Needs work » Needs review
StatusFileSize
new1.67 KB

Status: Needs review » Needs work

The last submitted patch, 13: field_group-multipage-submit-2147445-13.patch, failed testing.

bverc’s picture

StatusFileSize
new1.64 KB
bverc’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 15: field_group-multipage-submit-2147445-15.patch, failed testing.

bverc’s picture

Status: Needs work » Needs review
StatusFileSize
new1.64 KB

Looks like I can't get it to pass. Applies fine though. Marked as to not test to change status to Needs Review.

bverc’s picture

StatusFileSize
new1.67 KB

Forgot to change the selector in most recent patch.

Richard15’s picture

I changed line 33 of multipage.js with this code:

$('.form-actions', $form).remove().appendTo($($controls.parent(), $panes.last()));

simply adding ".parent()" to $controls

It seems working!

chris matthews’s picture

Assigned: balintbrews » Unassigned
Status: Needs review » Needs work
Issue tags: +Needs reroll

The 3 year old patch in #19 to multipage.js does not apply to the latest field_group 7.x-1.x-dev and needs a reroll (if still applicable).

Checking patch multipage/multipage.js...
error: while searching for:
        $controls = $('<div class="multipage-controls-list clearfix"></div>');?
        $(this).append($controls);?
?
        // Check if the submit button needs to move to the latest pane.?
        if (Drupal.settings.field_group.multipage_move_submit && $('.form-actions').length) {?
          $('.form-actions', $form).remove().appendTo($($controls, $panes.last()));?
        }?
?
        var multipageControl = new Drupal.multipageControl({?
          title: $('> .multipage-pane-title', this).text(),?
          wrapper: $(this),?

error: patch failed: multipage/multipage.js:28
error: multipage/multipage.js: patch does not apply
nils.destoop’s picture

Status: Needs work » Closed (won't fix)