Do not switch a site's default theme [#214689]

notice: Undefined variable: form_values in /var/www/www.astrocalc.com/htdocs/sites/all/modules/switchtheme/switchtheme.module on line 151.

a review with coder module shows:

switchtheme.module

    *
      severity: critical Line 151: use $form_state['values'] instead, which is where the values are stored after a submit

          variable_set('theme_default', $form_values['custom_theme']);

Comment	File	Size	Author
#3	switchtheme.patch	758 bytes	sun

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

yettyn CreditAttribution: yettyn commented 27 January 2008 at 10:28

and the fix:

changing variable_set('theme_default', $form_values['custom_theme']);

variable_set('theme_default', $form_state['values']['custom_theme']);
fixes it ;-)

Comment #2

yettyn CreditAttribution: yettyn commented 27 January 2008 at 10:28

Status:

Active

» Needs review

Comment #3

sun

German

Karlsruhe

CreditAttribution: sun commented 13 April 2008 at 19:52

Title:

Undefined variable: form_values

» Do not switch a site's default theme

File	Size
switchtheme.patch	758 bytes

IMHO, SwitchTheme should never ever allow users to switch the default theme of a site. This happens exactly in this line.

Instead of fixing this bug, I'd propose to remove the line completely.
The same change is already incorporated in the the patch in #185254: Themes don't switch for anonymous users.