Deprecated function: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in google_geocode_country_list() (line 74 of /sites/all/modules/location/geocoding/google.inc).

CommentFileSizeAuthor
#1 2144653-preg_replace_e_deprecated-1.patch528 bytesjeroent

Comments

jeroent’s picture

Status: Active » Needs review
StatusFileSize
new528 bytes

I'm not an regex expert but I don't know why the e is added at the end of the pattern. I deleted it, made a print_r of the clean country list before and after i removed the e at the end. Made a quick diff and the result is the same.

dancor’s picture

Title: Warnings ob webserver with PHP 5.5 in #overlay=admin/config/content/location/geocoding » Warnings of webserver with PHP 5.5 in #overlay=admin/config/content/location/geocoding
podarok’s picture

Version: 7.x-3.0 » 7.x-3.x-dev
Category: Bug report » Feature request
Status: Needs review » Postponed

postponing for now
5.5 is not development environment yet for drupal and we can`t remove functionality before it become mainstream
If You want to got this commited - You should create if/elseif statements(bad idea and spaghetti code) or disable deprecated warnings site wide via php.ini/.htaccess

mustanggb’s picture

Status: Postponed » Needs work

What functionality is removed?

The matched values are replaced with an empty string that contains no backreferences.

boobaa’s picture

Category: Feature request » Bug report
Status: Needs work » Reviewed & tested by the community

The patch does not remove functionality, but solves the issue clearly. Some may even think using the /e switch as a security issue, so simply let's ditch it.

podarok’s picture

Status: Reviewed & tested by the community » Fixed

#1 commited
Thanks!

  • Commit 215c464 on 7.x-3.x authored by JeroenT, committed by podarok:
    Issue #2144653 by JeroenT | dancor: Fixed Warnings of webserver with PHP...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Chetna_Negi’s picture

#1 worked.

Thanks JeroenT.