Hi Dan,

Just a heads up, I'm playing around with your new module Commerce Gift Card and as it requires the 7.x-.2x version of commerce Coupon, I installed the latest Commerce Coupon commit #8d14033 from Nov. 12, 2013. You are probably already aware of this, but I am seeing this Notice: Trying to get property of non-object in commerce_entity_access() (line 1026 of .../sites/all/modules/commerce/commerce.module). Is this something that might have been missed from 7.x-1x version.

Thanks! Keep up the great work!

CommentFileSizeAuthor
#2 2141801-2.patch555 bytesroderik

Comments

advernut’s picture

advernut commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Active » Needs review
StatusFileSize
new 2141801-2.patch555 bytes

Seeing this only when you clear the menu cache?

There's a faulty definition in commerce_menu() for admin/commerce/coupons/add. The 2nd argument to commerce_coupon_access() must be an entity, not a string.

advernut’s picture

advernut commented

That did the trick! Thanks roderik!

advernut’s picture

advernut commented
Status: Needs review » Fixed
roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Fixed » Reviewed & tested by the community

'fixed' means the fix is actually applied to the module's repository. I don't see it there.

(Setting to RTPC because tested, and because it's not an invasive patch that needs lots of testing.)

advernut’s picture

advernut commented

You are correct. My mistake. I'll wait for the patch to be added to the next 2x commit.

Thanks!

dpolant’s picture

dpolant commented
Status: Reviewed & tested by the community » Fixed

Fixed in latest dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.