Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Based on @webchick #1952394-192: Add configuration translation user interface module in core:
Went to admin/structure/views, clicked "Translate" under operations.
Only thing I can do from admin/structure/views/view/content/translate is edit the English translation. Right. I need to set up a language first. Always forget to do that when I test multilingual patches. (Help page didn't mention this step either.)@TODO: Maybe show a class=warning DSM that they only have one language enabled on screens like admin/structure/views/view/content/translate that links off to the languages admin page so I don't get blocked.
Steps to reproduce
- install drupal 8 head in english
- enable configuration translation (under Extend)
- go to a config translation page.. like admin/config/system/site-information/translate
Beta phase evaluation
| Issue category | Task, because there is no bug. |
|---|---|
| Issue priority | Normal since it is an isolated improvement |
| Prioritized changes | The main goal of this issue is usability |
| Disruption | No disruption. |
Proposed resolution
Show a Drupal message that another language needs to be set up IF the language of the config is the only language set up on the site (nothing to translate to). Note that this does not necessarily mean the language is English, it may be something else.
Remaining tasks
| Task | Novice task? | Contributor instructions | Complete? |
|---|---|---|---|
| Update the issue summary noting if allowed during the beta | Instructions | done | |
| Add steps to reproduce the issue | Novice | Instructions | done |
| Embed before and after screenshots in the issue summary | Novice | Instructions | done |
| Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards | Instructions | done |
User interface changes
Conditional message shown.
before
after
API changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 2139185-config-translation-language-hint-8.patch | 1.06 KB | penyaskito |
| #6 | before-configtrans.png | 197.41 KB | YesCT |
| #3 | 2139185-config-translation-language-hint-3.patch | 1.05 KB | penyaskito |
Comments
Comment #1
klonos...related issues should go to the metadata section.
I will add the specific comment link once we have #2132095: Allow defining specific comment # in related issues meta.
Comment #2
penyaskitoRolling the ball. I'm not sure why t() is double-escaping. SafeMarkup should be removed, but what should we use instead? Is inline_template needed for a simple dsm? I don't think so.
Comment #3
penyaskitoOK, discovered https://www.drupal.org/node/2445441. This one should be good to go.
Comment #4
YesCT CreditAttribution: YesCT commentedI will review this now.
Note #2019511: Explain why the language switcher would not show under some configurations is a bit related in trying to expose things to users where it matters.
Comment #5
penyaskitoOh, forgot about that one. I agree we should use a warning message.
Comment #6
YesCT CreditAttribution: YesCT commentedbefore and after in the issue summary, also some more cases:
Comment #7
YesCT CreditAttribution: YesCT commentedread the patch.
stays in scope.
is a good way to solve this.
-----
added a beta evaluation since this is a normal task.
Comment #8
penyaskitoThanks! Changed the warning too and updated screenshot
Comment #9
YesCT CreditAttribution: YesCT commentedYes. I'm still rtbc on that with the warning. thanks.
Comment #10
YesCT CreditAttribution: YesCT commentedupdating remaining tasks.
Comment #11
tstoecklerYay, thanks for picking this up. This still trips up a lot of people both learning Drupal but also avid core developers trying to test multilingual setups. Let's get this done.
RTBC++!
Comment #12
alexpottCommitted 7d3e205 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.
Comment #14
Gábor HojtsyYay, nice! Thanks all!