Problem/Motivation

Based on @webchick #1952394-192: Add configuration translation user interface module in core:

Went to admin/structure/views, clicked "Translate" under operations.
Only thing I can do from admin/structure/views/view/content/translate is edit the English translation. Right. I need to set up a language first. Always forget to do that when I test multilingual patches. (Help page didn't mention this step either.)

@TODO: Maybe show a class=warning DSM that they only have one language enabled on screens like admin/structure/views/view/content/translate that links off to the languages admin page so I don't get blocked.

Steps to reproduce

  1. install drupal 8 head in english
  2. enable configuration translation (under Extend)
  3. go to a config translation page.. like admin/config/system/site-information/translate

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because there is no bug.
Issue priority Normal since it is an isolated improvement
Prioritized changes The main goal of this issue is usability
Disruption No disruption.

Proposed resolution

Show a Drupal message that another language needs to be set up IF the language of the config is the only language set up on the site (nothing to translate to). Note that this does not necessarily mean the language is English, it may be something else.

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Update the issue summary noting if allowed during the beta Instructions done
Add steps to reproduce the issue Novice Instructions done
Embed before and after screenshots in the issue summary Novice Instructions done
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions done

User interface changes

Conditional message shown.

before

after

API changes

None.

Comments

klonos’s picture

Issue summary: View changes

...related issues should go to the metadata section.

I will add the specific comment link once we have #2132095: Allow defining specific comment # in related issues meta.

penyaskito’s picture

Status: Active » Needs review
Issue tags: +sprint
FileSize
1.32 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 95,182 pass(es). View

Rolling the ball. I'm not sure why t() is double-escaping. SafeMarkup should be removed, but what should we use instead? Is inline_template needed for a simple dsm? I don't think so.

penyaskito’s picture

FileSize
1.35 KB
1.05 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 95,181 pass(es). View

OK, discovered https://www.drupal.org/node/2445441. This one should be good to go.

YesCT’s picture

I will review this now.

Note #2019511: Explain why the language switcher would not show under some configurations is a bit related in trying to expose things to users where it matters.

penyaskito’s picture

Oh, forgot about that one. I agree we should use a warning message.

YesCT’s picture

before and after in the issue summary, also some more cases:

YesCT’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

read the patch.
stays in scope.
is a good way to solve this.

-----
added a beta evaluation since this is a normal task.

penyaskito’s picture

Issue summary: View changes
FileSize
1.09 KB
1.06 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 95,431 pass(es). View
46.19 KB

Thanks! Changed the warning too and updated screenshot

YesCT’s picture

Yes. I'm still rtbc on that with the warning. thanks.

YesCT’s picture

Issue summary: View changes

updating remaining tasks.

tstoeckler’s picture

Yay, thanks for picking this up. This still trips up a lot of people both learning Drupal but also avid core developers trying to test multilingual setups. Let's get this done.

RTBC++!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 7d3e205 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed 7d3e205 on 8.0.x
    Issue #2139185 by penyaskito, YesCT: Notify users when landing on config...
Gábor Hojtsy’s picture

Issue tags: -sprint

Yay, nice! Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.