TagCloud should count nodes with appropriate user rights..

// Based on https://api.drupal.org/api/drupal/modules%21comment%21comment.module/function/comment_get_recent/7
$query->innerJoin('node', 'n', 'tn.nid = n.nid');
$query->addTag('node_access');
CommentFileSizeAuthor
#6 tagclouds-2137603-5.patch773 bytesSnehal Brahmbhatt
#1 checknodeaccess-2137603.patch781 bytesfoxfabi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

foxfabi’s picture

foxfabi CreditAttribution: foxfabi commented
FileSize
checknodeaccess-2137603.patch781 bytes
giuvax’s picture

giuvax CreditAttribution: giuvax commented

I need this feature too. Is this patch to be committed in the next module version?

MGParisi’s picture

MGParisi CreditAttribution: MGParisi commented

I no longer have access to a test environment. I'll see what I can do. Any help would be appreciated.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews commented
Version: 7.x-1.9 » 7.x-1.x-dev
Status: Active » Needs work
Issue tags: +Needs reroll

The patch in #1 no longer applies to the latest 7.x-1.x development snapshot, needs reroll.

Checking patch tagclouds.module...
error: while searching for:
    $query->fields('td',array('tid', 'vid', 'name', 'description'));
    $query->fields('tn',array('nid'));
    $query->join('taxonomy_index', 'tn', 'td.tid = tn.tid');
    $query->join('node', 'n', 'tn.nid = n.nid');
    if (variable_get('tagclouds_language_separation', 0)) $query->condition('n.language', $language->language);
    $query->condition('td.vid', $vids);
    $query->condition('n.status', 1);

error: patch failed: tagclouds.module:224
error: tagclouds.module: patch does not apply
Pranali.addweb’s picture

Pranali.addweb CreditAttribution: Pranali.addweb at AddWeb Solution Pvt. Ltd. commented
Assigned: Unassigned » Pranali.addweb
Snehal Brahmbhatt’s picture

Snehal Brahmbhatt CreditAttribution: Snehal Brahmbhatt at AddWeb Solution Pvt. Ltd. commented
Status: Needs work » Needs review
FileSize
tagclouds-2137603-5.patch773 bytes

@Chris2, Please find my updated patch, I created it as per your mentioned latest comment. Hope this clear all issues.

Thanks!...

Status: Needs review » Needs work

The last submitted patch, 6: tagclouds-2137603-5.patch, failed testing. View results

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews commented
Assigned: Pranali.addweb » Unassigned
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs reroll

The test failed in #7, but it does apply cleanly on the command line:

git apply -v tagclouds-2137603-5.patch
Checking patch tagclouds.module...
Applied patch tagclouds.module cleanly.
andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
Issue tags: +TagCloud Release 7.x-1.12

andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.