Updated: Comment #N

Problem/Motivation

Drupal 7 had second level tabs on admin/people/permissions page which consisted of *Permissions* and *Roles* menu items. This is missing currently in Drupal 8 and there is no way to navigate to *Permissions* or *Roles* page.

Please find the attached screenshots for reference.

Proposed resolution

  • Add second level tabs to admin/people/permissions and admin/people/roles page.

Remaining tasks

User interface changes

Second level tabs for *Permissions* and *Roles* added to admin/people/permissions and admin/people/roles pages.

API changes

CommentFileSizeAuthor
#15 interdiff.txt2.62 KBdawehner
#15 user_roles-2135975.patch2.49 KBdawehner
#11 user_roles-2135975.patch2.75 KBdawehner
#11 interdiff.txt2.58 KBdawehner
#9 secondary-tabs-2135975.9.patch2.1 KBlarowlan
#9 interdiff.txt1.43 KBlarowlan
#6 secondary-tabs-2135975.pass_.patch1.37 KBlarowlan
#6 secondary-tabs-2135975.fail_.patch1.06 KBlarowlan
d8_permissions_page.png77.47 KBa_thakur
d7_permissions_page.png87.72 KBa_thakur
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

a_thakur’s picture

a_thakur CreditAttribution: a_thakur commented
Issue summary: View changes
a_thakur’s picture

a_thakur CreditAttribution: a_thakur commented
Status: Active » Needs work
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

Note that a while ago, Roles were moved to a top level local task, so there was People | Permissions | Roles, we should get back to that, not the 7.x way.

SteffenR’s picture

SteffenR
Primary language English
Location Bremen
CreditAttribution: SteffenR commented

Hi @Berdir - where can i find these new local tasks in the latest DEV of d8?
I installed the latest DEV and only find the Permissions Tab on the admin/people page.

I'm also wondering, that we do not show Roles and Permissions as sub items of the People menu.
Screenshot: http://img.port11.de/screenshots/20131209_083120.jpg

SteffenR

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue tags: +Needs tests
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Priority: Normal » Major
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
secondary-tabs-2135975.fail_.patch1.06 KB
secondary-tabs-2135975.pass_.patch1.37 KB

Regressions are major

The last submitted patch, 6: secondary-tabs-2135975.fail_.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 6: secondary-tabs-2135975.pass_.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
FileSize
interdiff.txt1.43 KB
secondary-tabs-2135975.9.patch2.1 KB

Fixes phpunit fails

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs work » Needs review
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
interdiff.txt2.58 KB
user_roles-2135975.patch2.75 KB

Let's make it more like Drupal 7.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

See comment #3, I agree with @berdir - the D7 way is pants. A top level tab is better.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Triple agree with Berdir

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Needs work

Woo, people agree with me ;)

Not that it would matter, this isn't about opinions.. It *was* changed to admin/people/roles before something broke it.

See #1262812: Make "Roles" a tab of "admin/people" instead of "admin/people/permissions".

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
Issue tags: +PHPUnit
FileSize
user_roles-2135975.patch2.49 KB
interdiff.txt2.62 KB

berdir++

The last submitted patch, 15: user_roles-2135975.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

15: user_roles-2135975.patch queued for re-testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

Thanks, confirmed that this is working.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Hm. Strange that we introduced this. It looks like it's code that just flat-out wasn't moved over. Anyway, glad to see it fixed + test coverage now.

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.