If i see this correctly, there is no double opt-in functionality in this module?

Comments

kasalla’s picture

Not so far. Mark this as Feature Request.

dercheffe’s picture

I would really appreciate this feature, too.

kasalla’s picture

Ok, Work is in progress,

By the end of the week a new version should be available.

filburt’s picture

Hi, any news for double opt-in?

elbeo’s picture

I second this feature request.
It has been quite a long week by now ;-)

kasalla’s picture

Assigned: Unassigned » kasalla
kasalla’s picture

Status: Active » Closed (fixed)

Available in the new dev version.

derhasi’s picture

Version: 7.x-1.0 » 7.x-1.x-dev
Assigned: kasalla » derhasi
Status: Closed (fixed) » Active

As we had to revert the changes for the other tickets, this is still not implemented. I have a look on the solution discussed in IRC.

derhasi’s picture

Title: No double opt-in? » Implement double opt-in
Status: Active » Needs review
StatusFileSize
new10.69 KB

The attached patch implements a Double-Opt-In Feature by using the formsSendActivationMail from the CleverReach API. This means for the moment you have to select a preconfigured form from the CleverReach API (See screenshot).

This way you have a unique appearance of your confirmation mail when you use the embedded form anywhere else.

derhasi’s picture

StatusFileSize
new10.01 KB

Reapplied patch after adding #2458481: Undefined index 'active' to dev.

derhasi’s picture

StatusFileSize
new10.04 KB
new648 bytes

Updated patch to fix form field description.

hctom’s picture

StatusFileSize
new10.46 KB
new482 bytes

Patch applies cleanly against the latest dev-release. I added another line in cleverreach_subscribe_form() so the cleverreach.subscribe.inc is loaded when the form is rebuilt from cache (this is for example needed when the form should be submitted via Ajax). Attached you can find the extended patch and an interdiff.

dercheffe’s picture

Any news about this issue? Unfortunately in Germany it's prohibited (data privacy laws) using a newsletter service without a double-opt-in procedure :(

derhasi’s picture

@dercheffe, did you test the patch?

das-peter’s picture

I've started working on a 2.x branch (https://github.com/CandoImage/drupal_cleverreach/tree/7.x-2.x) which comes with a code skeleton for the API (Makes developing using the SOAP Service easier).
I just added this patch :) Thanks!

anybody’s picture

Patch #12 (or #11) does not apply cleanly against latest .dev release for me. That's curious because the patch is newer than the latest 7.x-1.x-dev release... I'll keep you updated.

anybody’s picture

Ok I finally found out that this line leads to the problem:

; Information added by Drupal.org packaging script on 2015-03-24
version = "7.x-1.0+6-dev"
core = "7.x"
project = "cleverreach"
datestamp = "1427217788"

The patch doesn't know that line... and I think that's OK in general.

Patch #12 works great against latest .dev and I'll set it RTBC hereby. Is there an active maintainer who could create a new release containing this very important patch for German customers?

anybody’s picture

Status: Needs review » Reviewed & tested by the community
braintoilet’s picture

Yea, i will update the stable release soon to 7-1.1

  • braintoilet committed abf84da on 7.x-1.x authored by hctom
    Issue #2135241 by derhasi, hctom: Implement double opt-in
    
braintoilet’s picture

Status: Reviewed & tested by the community » Closed (fixed)

Thanks for the patch, added.

hoporr’s picture