Hi,

Found a small bug in the modal window settings: there are no setting 'background', there are 'background-color'. So your background color option doesn't work now.

Patch that solves this issue attached.

CommentFileSizeAuthor
modal_forms-wrong-background-option-in-the-modal-window.patch1.36 KBSpleshka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dpovshed’s picture

dpovshed CreditAttribution: dpovshed commented

Patch looks clean and simple for me.

Spleshka’s picture

Spleshka
he/him
Primary language English
Location UAE
CreditAttribution: Spleshka commented

Does it look like rtbc?)

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs review » Reviewed & tested by the community

+1 RTBC

Spleshka’s picture

Spleshka
he/him
Primary language English
Location UAE
CreditAttribution: Spleshka commented

Any progress in this issue?

Spleshka’s picture

Spleshka
he/him
Primary language English
Location UAE
CreditAttribution: Spleshka commented

Any feedback from maintainers so far?

frjo’s picture

frjo CreditAttribution: frjo commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x-1.x, thanks for the contribution.

  • frjo committed 03f68fa on 7.x-1.x authored by Spleshka 
    Issue #2134923 by Spleshka: Wrong background option in the modal window

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.