Hello.
I started porting your module for Drupal 8. The result you can see here: https://drupal.org/sandbox/eugene.brit/2123301

Files: 

Comments

mithy’s picture

Status:Patch (to be ported)» Active

Hi, thank you for bringing this issue up.

We should figure out whether this functionality has been implemented by other modules and whether we should discontinue this one. When I researched this for Drupal 7 there were other approaches like the core trigger module or the rules module, but none of them handled it correctly. That is why we decided to carry on, another point wa the huge flexibility the Login Destination gave. It improved a lot over the Drupal 6 (registration redirect, logout redirect).

However for a moment it is unlikely that me or any of the other developers would take a proper care of it due to the lack of time.

typhonius’s picture

Assigned:eugene.brit» typhonius

The repo hasn't moved for 7 months. Assigning to myself so rli and I can whirl this into shape as part of our D8 port blitz.

rli’s picture

Follow up.

typhonius’s picture

The module has been ported to D8. PHP snippet functionality has been removed (as the PHP module has been removed) and tests have been added.

Let us know if we're missing anything!

https://github.com/typhonius/drupal-login_destination-d8

gvso’s picture

Title:Port to Drupal 8» Port Login Destination to Drupal 8

Hi, I have been working to update @typhonius work to Drupal 8 beta4. Here is the link to the repository

https://github.com/GVSO/login_destination

gvso’s picture

Status:Active» Needs review
mithy’s picture

Thank you for all your work guys. Does any one of you want to become a maintainer of the 8.x version and a co-maintainer of this module ?

typhonius’s picture

@mithy, I'd be happy to help you out with this module. @gvso, once the initial changes have been merged in, we can continue to work on your additions and include them. An interdiff from my initial patch in #4and your additions would help!

gvso’s picture

FileSize
52.77 KB

Hi @mithy! I would like to help you with this module. @typhonius, here is my interdiff

gvso’s picture

FileSize
54.04 KB

Sorry, correcting extra spaces

typhonius’s picture

Assigned:typhonius» Unassigned

@mithy are we able to get a Drupal 8 branch set up against this project so patches can be applied against it? Thanks in advance!

mithy’s picture

8.x-1.x branch created.

In the meanwhile I tried to install the module but I get the following error during install process. I guess this might be because I have no working knowledge of D8 or the port is not complete. Is there any chance you can put a showcase on the web ?

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service "login_destination.manager" has a dependency on a non-existent service "request". in Symfony\Component\DependencyInjection\Compiler\CheckExceptionOnInvalidReferenceBehaviorPass->processReferences() (line 59 of /home/michal/www/drupal8/core/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php).

gvso’s picture

@mithy I wonder if you tried with the version that is in the repository https://github.com/GVSO/login_destination. I didn't use the @request service there and actually it doesn't use in D8 (it's a Symfony default service).

ddrozdik’s picture

Assigned:Unassigned» ddrozdik
Status:Needs review» Needs work

I will try finish and prepare 8.x version in short time.

ddrozdik’s picture

lookitscook’s picture

With 8.x-1.x the user/logout link is no longer working once module is enabled.

ddrozdik’s picture

Yeah, I know that interdiff file is not working. I'm already working on preparing 8 version.

sachbearbeiter’s picture

Hello,

did you find time to prepare the D8 version?

Thanks and regards
SB

ddrozdik’s picture

Work is in progress. And beta version will be ready soon. I do not have much time to focus only on this project ((.

sachbearbeiter’s picture

Thanks for the info ...
I absolutely don't want to push you ...

gvso’s picture

Is someone currently working on this? I would like to update the code if nobody already did it

ddrozdik’s picture

Hi @gvso, I have worked with new revised version of your code. But almost on the end I understood, that used solution for architecture is not the best, and I'm going to finish current alpha version, and start to work on refactoring. After porting some other modules to Drupal 8, now I better understand which drupal api should be used for this module.

gvso’s picture

Great @ddrozdik! I can give you access to the repository on my github, so you can commit your changes there.