The "git binary / The git binary is present and executable" status message in the site Status report page (/admin/reports/status) shows as an error (has a class="error"). Shouldn't it be class="ok" instead?
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | d7-fix-confusing-status-errors-2129795-11.patch | 1.73 KB | darren oh |
Comments
Comment #1
klonosComment #2
mustanggb commentedIf you're getting "error" instead of "ok" then it means (as per README.txt) that the git command is not executable by your webserver, i.e. either the functions "exec" or "git" aren't available (e.g. git isn't installed or the functions are disabled in your php.ini).
Once these two functions are available the class will change to "ok".
Comment #4
klonosSorry to resurrect this issue after such a long time, but the status-icon is still shown as error while the status-value is "The git binary is present and executable". Shouldn't it be "The git binary is EITHER NOT present OR NOT executable" instead?
Comment #5
klonos...perhaps an issue title change would help.
Comment #6
klonosIn other words, when the binary is present, the user gets an "ok" status and text. When the binary is missing, the user gets an error but the text still says "The git binary is present and executable". So, the user is puzzled: why the error message if the binary is present and executable?
Comment #7
juagarc4 commentedThis is because in the info file the text for the message is fixed with "The git binary is present and executable"
while the severity is changed in function of the existence or unexistence of the git and exec commands.
The severity determines then the icon to show, but the text is always the same.
The info file says:
We can test the requisites separately and set an understandable message according the problem. The severity ist set to ERROR if there is any error.
I have added a patch.
Comment #8
brianfisher commented+1 the current message is confusing.
Comment #9
darren ohComment #10
darren ohComment #11
darren ohPorted fix from #3079539: Run exec() checking when module is installed as it would not work at all without it.
Comment #12
darren ohUploaded wrong patch.
Comment #13
darren ohComment #15
darren oh