Remaining D6 issues

#2130593: Write a special process plugin for variable to config: system.date Assigned to: fastangel
#2132217: Variable to config: user.settings Assigned to: remydenton

  1. Find an Active, unassigned "Variable to config:" issue
  2. Assign it to yourself when you start work on it
  3. Convert it, write a test and submit

To elaborate:

  1. Your guidelines are config/migrate.migration.d6_system_site.yml, lib/Drupal/migrate/Tests/MigrateSystemConfigsTest.php, lib/Drupal/migrate/Tests/Dump/Drupal6SystemSite.php
  2. Copy paste the update_variables_to_config call into the provided converter script and run it from your Drupal root. It will create the migration entity for you.
  3. Create your Dump class based on the source variables and any values you like. It's preferred to use the default values for the variables from D6 but if that's too much work, we are good with any values.
  4. If your module does not already have a MigrateModuleNameConfigsTest.php, create it. Now add a method for this specific config file based on the testSystemSite method which should be self explanatory: you need to change the second argument of the entity_load to the id found in the yaml (both file name and inside as id:), the dump path, the name of the config() and all the asserts.
  5. Note that the test you are writing is a simpletest; full integration tests can't be done in phpunit (or not well). To execute simpletests from the command line, see https://drupal.org/node/645286

    Note #2: our only guide in these migration is the update_variables_to_config call. However, some variables didn't exist in D6 or had a different name. For these, please use the D6 variable name and leave a note on the issue that there are D7 variables to be ported. After commit I will set them to postponed and add a D7 to the issue title.

Comments

chx’s picture

StatusFileSize
new701 bytes
chx’s picture

Issue summary: View changes
chx’s picture

Issue summary: View changes
chx’s picture

Issue summary: View changes
chx’s picture

StatusFileSize
new729 bytes
chx’s picture

StatusFileSize
new1.11 KB
chx’s picture

StatusFileSize
new672 bytes
chx’s picture

StatusFileSize
new684 bytes

Updated the script for the from-to swap as agreed with Mike Ryan.

chx’s picture

Issue summary: View changes
chx’s picture

StatusFileSize
new677 bytes

Updated the script for the new, past pivot reality.

eliza411’s picture

Issue summary: View changes
chx’s picture

Issue summary: View changes
eliza411’s picture

Issue summary: View changes
chx’s picture

StatusFileSize
new624 bytes
xjm’s picture

I dumped a bit from the summary into https://drupal.org/node/1429136. Can someone polish it and make it make sense, and maybe look into writing more generalized docs for migration tests?

chx’s picture

Issue summary: View changes
eliza411’s picture

Issue summary: View changes
eliza411’s picture

Project: IMP » Drupal core
Version: » 8.x-dev
Component: Code » migration system

Moving to the core queue to consolidate issues now that we're doing all the work there.

xjm’s picture

Title: [meta] Variables to config » [meta] Variables to config migration

I keep confusing this issue with the CMI issue so clarifying title. :)

chx’s picture

Status: Active » Fixed

I deem this fixed.

xjm’s picture

Status: Fixed » Active

There are still variables in core, and an open child issue?

eliza411’s picture

Title: [meta] Variables to config migration » [meta] Variables to config migration [D6]
Issue summary: View changes

Updating to highlight remaining issues

chx’s picture

StatusFileSize
new624 bytes
hass’s picture

I have no differences in variable names bettwen D6 and D7. Is it correct that D7 variables migration is 1:1 copy of D6 and the only change is the name of "id:" e.g. <strong>d7</strong>_google_analytics_settings under source we use plugin: drupal6_variable for D7 migration, too? Or is there any special drupal7_variable plugin?

chx’s picture

The d6_variable plugin has been renamed recently to variable and it is used equally in d6 and d7 migrations. Hope that helps.

benjy’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.