modules/menu/menu.install:103: update_variables_to_config('menu.settings'
modules/menu/menu.install:58: update_variables_to_config('menu.settings'

Renamed variables

menu_primary_links_source => [default value]

  • D6: menu_primary_links_source => 'primary-links'
  • D7: menu_main_links_source => 'main-menu'
  • D8: menu.settings.main_links => 'main'

menu_secondary_links_source => [default value]

  • D6: menu_secondary_links_source => 'secondary-links'
  • D7: menu_secondary_links_source => 'user-menu'
  • D8: menu.settings.secondary_links => 'account'

menu_default_node_menu => [default value]

  • D6: menu_default_node_menu => 'primary-links'
  • D7: menu_options_{$content_type} => array('main-menu' => 'main-menu')
  • D8: same as D7 -- not yet converted to config

Thanks in advance for helping many hands to make light work!
See #2125745: [meta] Variables to config migration [D6] for instructions

CommentFileSizeAuthor
#13 imp_2130315-13_migrate-menu.settings-D6-to-D8.patch5.03 KBjessehs
#7 imp_2130315-1_migrate-menu.settings-D6-to-D8.patch4.31 KBadamdicarlo
#6 imp_2130315-1_migrate-menu.settings-D6-to-D8.patch0 bytesadamdicarlo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

adamdicarlo’s picture

adamdicarlo CreditAttribution: adamdicarlo commented
Assigned: Unassigned » adamdicarlo
Category: Task » Bug report
adamdicarlo’s picture

adamdicarlo CreditAttribution: adamdicarlo commented
Category: Bug report » Task
fastangel’s picture

fastangel CreditAttribution: fastangel commented

Hey adamdicarlo. Do you need help you with this?

adamdicarlo’s picture

adamdicarlo CreditAttribution: adamdicarlo commented

hi fastangel. Thanks - I'm on IRC now (#drupal-contribute) but I *think* I have it covered. I'm doing the sprint in Portland today. I almost finished the patch for this issue.

adamdicarlo’s picture

adamdicarlo CreditAttribution: adamdicarlo commented
Issue summary: View changes
adamdicarlo’s picture

adamdicarlo CreditAttribution: adamdicarlo commented
Status: Active » Needs review
FileSize
imp_2130315-1_migrate-menu.settings-D6-to-D8.patch0 bytes

First patch attached. It migrates just three variables from D6 -> D8:
menu_primary_links_source
menu_secondary_links_source
menu_override_parent_selector

There are still variables in menu.module (in D8) not converted to CMI, however.

adamdicarlo’s picture

adamdicarlo CreditAttribution: adamdicarlo commented
FileSize
imp_2130315-1_migrate-menu.settings-D6-to-D8.patch4.31 KB
adamdicarlo’s picture

adamdicarlo CreditAttribution: adamdicarlo commented
Assigned: adamdicarlo » Unassigned

Won't have time to work on this soon, so unassigning. I hope my patch helps!

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Postponed
Related issues: +#2102521: Finish converting menu.module to CMI

Crosslinking issues. Holding this up until.

chx’s picture

chx CreditAttribution: chx commented
Status: Postponed » Needs work

Related issue is in.

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
CreditAttribution: jessehs commented
Assigned: Unassigned » jessehs
chx’s picture

chx CreditAttribution: chx commented
Project: IMP » Drupal core
Version: » 8.x-dev
Component: Code » migration system
jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
CreditAttribution: jessehs commented
Status: Needs work » Needs review
FileSize
imp_2130315-13_migrate-menu.settings-D6-to-D8.patch5.03 KB

The variables mentioned in the issue about menus available for each node type are for Drupal 7 only, I believe.

I've rerolled the patch to apply against HEAD.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Closed (duplicate)

Rolled into #2154955: Migrate variables to config