Hi,

I think we need a better way to display the result, than a drupal message. This way, it can be easier to customise, move around, and well, look better :)

Comments

kbahey’s picture

You have a patch for that?

Anonymous’s picture

No i don't.

2222a’s picture

I second this request too. It needs to stand out. Sadly I have no clue on how to do it through

chriscohen’s picture

StatusFileSize
new35.65 KB

This is not exactly a patch, but rather the whole thing as a zip file. I'm sorry but I have no idea how to turn this into a patch. I'm hoping someone else will be able to do this.

This is a modified copy of 5.x-1.1, with a new sub-module called 'currency_toolbox'. It adds a new, blank form field to the currency form, and when the 'convert' button is clicked, an AJAX function is called and the conversion takes place, putting the converted amount into the empty form field, negating the need to reload the page at all.

There are a couple of issues with this approach, but my development time has run out on the site where this is used, so I presently cannot continue development.

  • The AJAX part resides in a separate module (mainly so that I can use a separate part of the repository). This could probably be put in the main currency module.
  • There is no visual indicator (like a throbber or something) between the user clicking 'convert' and the currency conversion being returned, so the user has no feedback in the case when it takes a long time to convert.
  • There is no check performed as to whether cURL is enabled. This will cause the conversion to fail silently instead of providing the user with feedback (especially important because most default installs of PHP have cURL disabled).
amateescu’s picture

Version: master » 6.x-1.x-dev
Status: Active » Postponed

The 5.x branch is not maintained anymore. Maybe we can fix this in 6.x.

amateescu’s picture

Assigned: Unassigned » amateescu
Status: Postponed » Active

Will write a patch for this in a couple of days.

amateescu’s picture

Status: Active » Needs review
StatusFileSize
new7.02 KB

And here is the patch.

amateescu’s picture

Status: Needs review » Fixed

Commited with 7219c81.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

shyamprakash’s picture

Hello all i have configure currency module (Drupal 6) functionality is fine but we need to Better display of result would you pls help?

shyamprakash’s picture

StatusFileSize
new30.56 KB