Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
there is an issue when I try to use jquery 1.9. The jQuery.browser property was removed in jQuery 1.9, which is used in extlink.js line 115.
http://api.jquery.com/jQuery.browser/
http://stackoverflow.com/questions/14892095/browser-msie-error-after-upd...
Comment | File | Size | Author |
---|---|---|---|
#4 | extlink-2124457-1.patch | 556 bytes | elachlan |
Comments
Comment #1
elachlan CreditAttribution: elachlan commentedThe code in question:
Both
$.support
and$.browser
are either deprecated or no longer advised to be used. This peice of code is used because of box model problems in ie 7 and below see http://en.wikipedia.org/wiki/Internet_Explorer_box_model_bug.This post says that you should force it using the doctype, which would mean we could remove that code and just tell people to avoid quirks mode.
http://stackoverflow.com/questions/4007866/how-to-solve-ie6-box-model-pr...
For reference, here is the previous issue #795360: Mailto and Extlink images not showing.
Comment #2
elachlan CreditAttribution: elachlan commentedComment #3
elachlan CreditAttribution: elachlan commentedComment #4
elachlan CreditAttribution: elachlan commentedFirst patch.
Removed the offending line.
Based off of feedback from a previous issue, we are going to avoid support for anything below IE8.
This will need lots of testing.
Comment #6
elachlan CreditAttribution: elachlan commentedVersion needs to be DEV to test against latest changes.
Comment #7
elachlan CreditAttribution: elachlan commented4: extlink-2124457-1.patch queued for re-testing.
Comment #8
duntuk CreditAttribution: duntuk commentedFYI, 4: extlink-2124457-1.patch works. Tested on DEV.
Comment #9
quicksketchLooks like this wasn't applied to the 7.x-1.x branch, so I committed it there as well. Thanks guys!