there is an issue when I try to use jquery 1.9. The jQuery.browser property was removed in jQuery 1.9, which is used in extlink.js line 115.
http://api.jquery.com/jQuery.browser/
http://stackoverflow.com/questions/14892095/browser-msie-error-after-upd...

CommentFileSizeAuthor
#4 extlink-2124457-1.patch556 byteselachlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

elachlan’s picture

Priority: Normal » Critical

The code in question:

// Work around for Internet Explorer box model problems.
  if (($.support && !($.support.boxModel === undefined) && !$.support.boxModel) || ($.browser.msie && parseInt($.browser.version) <= 7)) {
    $('span.ext, span.mailto').css('display', 'inline-block');
  }

Both $.support and $.browser are either deprecated or no longer advised to be used. This peice of code is used because of box model problems in ie 7 and below see http://en.wikipedia.org/wiki/Internet_Explorer_box_model_bug.

This post says that you should force it using the doctype, which would mean we could remove that code and just tell people to avoid quirks mode.
http://stackoverflow.com/questions/4007866/how-to-solve-ie6-box-model-pr...

For reference, here is the previous issue #795360: Mailto and Extlink images not showing.

elachlan’s picture

Issue summary: View changes
elachlan’s picture

elachlan’s picture

Status: Active » Needs review
FileSize
556 bytes

First patch.

Removed the offending line.

Based off of feedback from a previous issue, we are going to avoid support for anything below IE8.

This will need lots of testing.

Status: Needs review » Needs work

The last submitted patch, 4: extlink-2124457-1.patch, failed testing.

elachlan’s picture

Version: 7.x-1.13 » 7.x-1.x-dev
Status: Needs work » Needs review

Version needs to be DEV to test against latest changes.

elachlan’s picture

4: extlink-2124457-1.patch queued for re-testing.

duntuk’s picture

FYI, 4: extlink-2124457-1.patch works. Tested on DEV.

quicksketch’s picture

Status: Needs review » Fixed

Looks like this wasn't applied to the 7.x-1.x branch, so I committed it there as well. Thanks guys!

  • Commit 7147c53 on 7.x-1.x by quicksketch:
    Issue #2124457 by elachlan | funature: Compatibility of jquery >=1.9.
    

  • Commit 3c909e7 on 6.x-1.x by quicksketch:
    Issue #2124457 by elachlan | funature: Compatibility of jquery >=1.9.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.