Project d.o page: https://drupal.org/sandbox/clrh/1866840
Website: http://wheke.org
Branch: 7.x-2.x on http://git.drupal.org/sandbox/clrh/1866840.git
What is it : A drupal installation profile and distribution for libraries

Where is it and how I build it:
$ git clone --branch 7.x-2.x http://git.drupal.org/sandbox/clrh/1866840.git wheke
$ drush make wheke/build-wheke.make $DIR_INSTALL --working-copy
$ cd $DIR_INSTALL
$ drush si -y wheke --account-name=$ACCOUNT_NAME --account-pass=$ACCOUNT_PASS --db-url='mysql://'$MYSQL_USER':'$MYSQL_PASS'@'$MYSQL_SERVER'/'$MYSQL_DB --locale=fr

First, we provided our first module called opac. The opac module enables libraries to integrate their catalog into Drupal allowing importing records, make advanced searches with faceted results, circulation task etc ... This module is intended to work with any ILS by using connectors (koha_connector is the first to be alive). Everyone can make its own by creating a php file. We are working too with pazpar2 for federated search with mkdru and plan to develop an ERM soon.

We needed a Drupal distribution with modules preconfigured for helping libraries to build their website. It is the aim of this project. We are building a website dedicated: http://wheke.org

Comments

vijaycs85’s picture

Status: Needs review » Needs work

Thanks for your effort to provide a distribution/platform to libraries. Here are my few initial findings:

1. http://pareview.sh/pareview/httpgitdrupalorgsandboxclrh1866840git - There are some basic coding standard complaints that we need to fix. once you fix the code, you can repeat the test to get the new code base status.
2. Other than downloading the real code, I couldn't find whether it is module/theme/profile. Can we make it clear in description please?

Claire Hernandez’s picture

Status: Needs work » Needs review

1. The branch where I worked is 7.x-2.x it should pass ventral, dcs and verify-makefile: http://pareview.sh/pareview/httpgitdrupalorgsandboxclrh1866840git-7x-2x

2. I changed the issue description to make it clearer

Thanks.

vijaycs85’s picture

Thank for your update @Claire Hernandez. I will install and check the functionality later today or tomorrow.

PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

vijaycs85’s picture

Manually installed (As specified in 'Where is it and how I build it:') and here is my findings:

1. Got few warning message on install
Screen Shot 2013-10-19 at 15.07.54.png

2. After logged in, can see list of modules enabled by default on modules list page.

vijaycs85’s picture

duplicate of #5

vijaycs85’s picture

Issue summary: View changes

description changed

Claire Hernandez’s picture

Warnings should have disapear because I fixed the guilty module (flag_cart), released it and updated the branch with the new 1.1 flag_cart version.

Thanks.

vijaycs85’s picture

Issue tags: +Needs manual testing

Ok, lets update the tag to someone manually instal this and produce result.

Bès’s picture

FileSize
43.73 KB

Hi here,

just go throw the installation process. First remark, it's based on Drupal 7.22, may need to update to 7.23.
No error, except at the end but it's due to my computer configuration.

wheke installation

Will now try to play with the distribution

Claire Hernandez’s picture

I fixed things:
* core version
* security version of ds

Regards.

Claire Hernandez’s picture

Issue summary: View changes

fix a mini mistake in "how to"

Claire Hernandez’s picture

Claire Hernandez’s picture

To help "functionnal test" (not easy I know, because you should setup a library integrated system to use it completly), I will try to give you some hints:

One built you can see:

- a basic but theme wich match with wheke-demo ad wheke.org website (should be responsive and based on prt)
home and theme
- custom configurations for a unimarc lis (you can harvest a lis like koha to have bibliographic records as node in drupal)
custom opacserver config
- some specific modules as search
Only local images are allowed.
- you can see opac in configuration
opac config
- custom configuration for authentication between drupal and lis and borrower (member of library) recognition
authentication with lis
- biblio and journal ct with associated displays
biblio ct
journal ct
- item customisations
item custom things
- authorities configurations
auth config

I think I am not exaustive, but you can look forward I hope :)

Hope it helps !

kscheirer’s picture

Status: Needs review » Reviewed & tested by the community
  • It's a distro! I was a little confused by the text on the project page that still says "planning". Could you rewrite to reflect what the profile does and why someone would want to use it?
  • You have a lot of branches! Are all of those still being used?
  • You can remove the .gitignore file.

Otherwise looks good to me. I did not actually install the distro though.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Claire Hernandez’s picture

Hello,

  • About page is reviewed https://drupal.org/sandbox/clrh/1866840
  • About branches, it is commiters workflow wich is like this. You need only the main branch of course. If it distrurbs the community, we can remove its.
  • .gitignore is removed

Thanks for feedbacks.

kscheirer’s picture

Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Hi Claire,

I'm happy to promote this distribution to a full release.

However, it doesn't seem like you've written any of the code, so we cannot grant you "git vetted user" status to promote your own projects.

Please let us know how you'd like to proceed and if I've made an error.

Claire Hernandez’s picture

Hi Karl,

Thanks for review.

This repository has not a lot of "code", it is a lot of packaging, modules versionning, not just php instructions. However, I am the main maintainer of wheke distribution (131 commits https://drupal.org/sandbox/clrh/1866840). I am involved into main opac module (and others) and wheke team as code reviewer, documentation writer, tester, translator, infrastructure maintainer, architecture validator, I do releases too and fix things when they need it. I know perhaps I am not a "developper" as you mean, but I think my implication is not insignificant.

It is up to you to decide ;)

Claire Hernandez’s picture

Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

I think status should changed (not sure, I hope I don't do a mistake)

Claire Hernandez’s picture

What does it miss to this issue ? 2 months ago, you were ready to promote this project. Did you change your mind ? What could I do to help ?

jneubert’s picture

Hi Claire,

Your distribution sounds quite interesting, so I tried to install it, following your description above. All went fine untill the step

[root@nbt3 drupal_wheke]# drush si -y wheke --account-name=admin --account-pass=secret --db-url='mysql://root:secret@localhost/drupal_wheke' --locale=fr
You are about to create a sites/default/files directory and create a sites/default/settings.php file and CREATE  the 'drupal_wheke' database. Do you want to continue? (y/n): y
Starting Drupal installation. This takes a few seconds ...           [ok]
WD php: PDOException: SQLSTATE[42000]: Syntax error or access        [error]
violation: 1072 Key column 'form_name' doesn't exist in table: CREATE
TABLE {simplesearch_blocks} (
`block_name` VARCHAR(255) NOT NULL,
`block_title` VARCHAR(255) NOT NULL,
`block_conf` BLOB DEFAULT NULL,
PRIMARY KEY (`form_name`)
) ENGINE = InnoDB DEFAULT CHARACTER SET utf8 COMMENT 'Available
blocks.'; Array
(
)
 in db_create_table() (line 2717 of
/opt/drupal_wheke/includes/database/database.inc).
WD php: Warning: Cannot modify header information - headers already  [warning]
sent by (output started at /opt/drush/includes/output.inc:37) in
drupal_send_headers() (line 1216 of
/opt/drupal_wheke/includes/bootstrap.inc).
PDOException: SQLSTATE[42000]: Syntax error or access violation: 1072 Key column 'form_name' doesn't exist in table: CREATE TABLE {simplesearch_blocks} (
`block_name` VARCHAR(255) NOT NULL,
`block_title` VARCHAR(255) NOT NULL,
`block_conf` BLOB DEFAULT NULL,
PRIMARY KEY (`form_name`)
) ENGINE = InnoDB DEFAULT CHARACTER SET utf8 COMMENT 'Available blocks.'; Array
(
)
 in db_create_table() (line 2717 of /opt/drupal_wheke/includes/database/database.inc).
Drush command terminated abnormally due to an unrecoverable error.   [error]

The database itself and a number of tables have been created, so the basic setup seems to work.

Two additional comments:

1) During make, Drupal 7.23 is downloaded. If this isn't updated later on automatically, you perhaps should consider downloading always the current version (in the meantime, Drupal 7.24 and 7.26 fixed security issues).

2) From the build description above it was not clear to me if mysql as a database and language=fr are restrictions, or just example values. If English is supported, or other databases, it could be helpful to mention that explicitely.

Cheers, Joachim

jneubert’s picture

Status: Reviewed & tested by the community » Needs work
PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Claire Hernandez’s picture

Status: Closed (won't fix) » Reviewed & tested by the community

I fixed a mistake in a linked module (simplesearch).
So back to the last status "reviewed & tested by the community".
I should me more present than these last 4 months...

Regards.

gisle’s picture

Status: Reviewed & tested by the community » Needs work
Manual Review
Claire Hernandez’s picture

Status: Needs work » Reviewed & tested by the community
README.txt
No: Does not follows the guidelines for in-project documentation, including the guidelines for README.txt.

>> b85dcea README.txt file change regarding the template https://drupal.org/node/2181737

Master Branch
No: Follows the guidelines for master branch, but the default branch is not set to the branch under review (7.x-2.x).

>> Now default branch is 2.x

Coding style & Drupal API usage

The automatic review found one error affecting one line. Please see: PAreview for details. This is trivial to fix, but need to be fixed before a release.

Pareview is now clean !

Regards.

gisle’s picture

Status: Reviewed & tested by the community » Needs review

Please note: You're not supposed to change the status to from "Needs work" to Reviewed & tested by the community" (RTBC) yourself (from the look at #17, #22, #24, it looks as if you're confused about this).

After you think you've fixed all the problems pointed out in a review, you change the status from "Needs work" to "Needs review". This indicates that you think the project is ready for a new review. You're not supposed to review your own project.

After the reviewer has had time to review the new version, he or she has two main options: To point out that there are still points that need to fixed, and set the status to "Needs work". Or to set the status to "Reviewed & tested by the community" to indicate that the reviewer now thinks the project is ready to be promoted into a full project. Note that this status in no guarantee of promotion. There may be other reviewers that disagree, and that may push it back down to "Needs work".

Claire Hernandez’s picture

Oups... Ok I understand, thanks Gisle.

gisle’s picture

Status: Needs review » Reviewed & tested by the community

There are IMHO no more blockers. Moving to RTBC. Note that promotion will not happen until a git administrator has given this a second set of eyes.

Also note that it it does not follow the guidelines for project length and complexity (see also #15). It usually entails that project is promoted to full project status, but the applicant does not gain git vetted stattus (but the git administrator makes the final call on this as well).

gisle’s picture

Added tag.

kscheirer’s picture

Status: Reviewed & tested by the community » Fixed

Sorry for my absence Claire! I think your Drupal history shows enough work, and you're even listed as a mentor by another contributor with many commits. Checked for security, licensing, and account issues, I don't see any.

Thanks for your contribution, Claire Hernandez!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.