Call to a member function label() on a non-object

Refactored entity_ui_get_page_title to avoid function call on non-object in entity_label when $entity is NULL. Patched against latest dev version.

Patch #6 works for me against 7.x-1.5 and solves the problem I was having with Mailchimp module. Holding of on RTBC this until I've tested a bit more but looking good so far.

#6 works for me and solves a problem with importing Workflows. Commit ASAP IMO.

Nothing has gone boom after over a week so RTBC.

Agreed, patch in #6 is fine

Although this issue should be resolved asap, the patch in #6 is broken. By removing the check for an entity, you're just moving the WSOD further down the line, check entity_extract_ids():

  if (!empty($info['entity keys']['bundle'])) {
    // Explicitly fail for malformed entities missing the bundle property.
    if (!isset($entity->{$info['entity keys']['bundle']}) || $entity->{$info['entity keys']['bundle']} === '') {
      throw new EntityMalformedException(t('Missing bundle property on entity of type @entity_type.', array('@entity_type' => $entity_type)));
    }
    $bundle = $entity->{$info['entity keys']['bundle']};
  }

Attached is a different approach.

The patch in #11 fixes this bug for me, as it occurs in the CER module: #2341403: WSOD at admin/config/content/cer/import. Marking RTBC.

#11 looks good

+++ b/entity.module
@@ -184,28 +184,30 @@ function entity_ui_entity_page_view($entity) {
   return entity_ui_get_action_title($op, $entity_type, $bundle);

This now calls entity_ui_get_action_title() with other than the support opersations, thus is bogus.

I'd suggest keeping the old flow instead but falling back to another label if no $entity is given, e.g. the entity type label.

I'm not sure...

How does it call that entity_ui_get_action_title() with any $op except 'add' and 'import'? Any other operation requires an entity ('edit', 'clone', 'delete', 'revert', 'view', 'export') and would thus get caught in the switch.

The only ones that should fall through are the ones that generally don't need an entity at all: 'add', 'import' and any other unsupported operator that someone should manually pass on, which would break anyway.

Any other operation requires an entity ('edit', 'clone', 'delete', 'revert', 'view', 'export') and would thus get caught in the switch.

Not any more if the entity is NULL. The documentation says I can call it without entity in all cases, thus it should work in all of those cases. I'd suggest generating $label as the entity type label if no entity is passed and keeping the existing flow of things.

Okay, I'll try to update the patch when I can (currently at Drupalcon).

There is my patch with generating $label as entity type label if $entity = NULL.

@ofry, it looks like that patch had bad header information (it contained the full path to your clone of Entity API, starting with "C:/"), so the testbot couldn't handle it. I have re-rolled the patch and attached it.

The patch in #18 (copied in #20) contains several flaws:

• You check for an entity and when there isn't one, try to extract the bundle
• You copy code from entity_ui_get_action_title() instead of just calling that function
• Whitespace at the end of a line (meh)
• You added a new return value

Here's a streamlined and modified version of @ofry's patch, addressing the issues you mentioned. Even the whitespace. ;)

Nah, screw that, here's a better one.

Hiding broken patches in issue summary.

Isn't this much cleaner?

It takes a small hit on extracting the bundle whether you need it or not, but has all the checks at the top.

#23 looks clean too, so I'm even.

I like your version better. #25 looks great to me.

Great, back to fago then :)

Thanks, committed.