Hi Yonas,

I packed a few updates together and thought these would are quite helpful. Let me know if your thoughts.

  • Updated field array in the install file for readability
  • Removed the last_sent field - not being used
  • Removed the disp-width attribute for active field - not necessary
  • Set active to disabled - we shouldn't be writing to the DB by default for every new draft
  • node_reminder_save is called only when the reminder is enabled

Thanks!
Alex

Comments

mralexho’s picture

Oops, there was a missing comma in the schema array. Fixed.

fizk’s picture

Thanks Alex! I'm going to go through this asap.

mralexho’s picture

Thanks Yonas!

I just realized I can't call node_reminder_save only when $reminder->active is true because it won't update if the user decides to disable the reminder.

I'll figure something out that doesn't require updating node on each save but also allowing the user to enable/disable reminders.

Alex

mralexho’s picture

Oops, I accidentally set the notify_on size to tiny and thus, node_save will not execute.

Please see fix. Sorry.

fizk’s picture

Issue summary: View changes
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.