Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Oct 2013 at 18:12 UTC
Updated:
29 Oct 2013 at 18:00 UTC
In a project we need to have a convenient and easy way to limit the amount of items per menu.
Menu Item Limit provides an easy way to setup limits for seperate menus by adding a custom form element and custom validation checks.
https://drupal.org/sandbox/Cyberschorsch/2111321
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Cyberschorsch/2111321.git menu_item_limit
http://pareview.sh/pareview/httpgitdrupalorgsandboxcyberschorsch2111321git
Comments
Comment #1
dawehner// Implements hook_form_alter().should be
Comment #2
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
cyberschorschThank you Daniel for the quick review :)
I added the menu module as dependency and fixed the code-style issues. I also removed the files from the master branch, I tried to delete it but somehow failed.
Comment #4
ajitsAutomated review:
pareview.sh found some problems with the project. Please fix those.
Manual review:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Cyberschorsch/2111321.git menu_item_limit.menu_item_limit_config_menu_submit(), you are setting a variable with the prefix of the module name. You should implementhook_uninstall()in your module and delete this variable on module uninstall usingvariable_del().Comment #4.0
ajitsAdded link to pareview.
Comment #5
cyberschorschThank you for your review AjitS :)
I moved the README.md to README.txt and added more information to it. I also added a hook_uninstall to clean up leftover variables.
Comment #6
cyberschorschComment #7
dawehnerI am fine with that as it is
Comment #8
stborchertThanks for your contribution, Lucio!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
*Woot*. Fixed in less than 24 hours :)
Comment #9.0
(not verified) commentedFixed git clone link