Description

In a project we need to have a convenient and easy way to limit the amount of items per menu.
Menu Item Limit provides an easy way to setup limits for seperate menus by adding a custom form element and custom validation checks.

Link to project page

https://drupal.org/sandbox/Cyberschorsch/2111321

Git

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Cyberschorsch/2111321.git menu_item_limit

PAReview

http://pareview.sh/pareview/httpgitdrupalorgsandboxcyberschorsch2111321git

Other Projects

https://drupal.org/project/commerce_google_analytics

Comments

dawehner’s picture

  • I would recommend to empty the master branch, so it is clear that 7.x-1.x is the place where stuff happens
  • What about adding a dependency to the menu module? I am not sure anymore whether menu was actually required in D7 (yeah yeah the good old times)
  • Some minor code-style issues: There should be a new line between the end of a function and the documentation of the next one.
  • // Implements hook_form_alter().
    should be
    /**
     * Implements hook_form_alter().
     */
    
PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

cyberschorsch’s picture

Thank you Daniel for the quick review :)

I added the menu module as dependency and fixed the code-style issues. I also removed the files from the master branch, I tried to delete it but somehow failed.

ajits’s picture

Status: Needs review » Needs work

Automated review:

pareview.sh found some problems with the project. Please fix those.

Manual review:

  1. Your GIT clone link clones into a directory named 2111321, instead of the module name menu_item_limit. To rectify this change the GIT clone link to : git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Cyberschorsch/2111321.git menu_item_limit.
  2. Rename your README.md file to README.txt
  3. In menu_item_limit_config_menu_submit(), you are setting a variable with the prefix of the module name. You should implement hook_uninstall() in your module and delete this variable on module uninstall using variable_del().
ajits’s picture

Issue summary: View changes

Added link to pareview.

cyberschorsch’s picture

Thank you for your review AjitS :)

I moved the README.md to README.txt and added more information to it. I also added a hook_uninstall to clean up leftover variables.

cyberschorsch’s picture

Status: Needs work » Needs review
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

I am fine with that as it is

stborchert’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, Lucio!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

*Woot*. Fixed in less than 24 hours :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Fixed git clone link