[D7] Jquery Event Calendar

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxkareemzok2105751git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Kareem,

Here's my review of your module.

Boilerplate stuff

An automated review of your project has found some issues with your code. Most of the issues appear to be with code formatting and whitespace, and while fixing all issues is not a requirement for getting through the application process, it's a good idea to fix them so that reviewers can better read your code.

http://pareview.sh/pareview/httpgitdrupalorgsandboxkareemzok2105751git

There are tons of other event calendar modules that provide similar functionality. Could you describe how your module differs?

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch.

jQuery Event Calendar appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.

The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.

Module functionality review

The package = Ebiz setting in your .info file is a bit confusing. What is Ebiz? You may want to consider removing that.

Installation of the module fails because of a missing dependency on the date module. You should add date as a module dependency in your .info file.

After I enable the module, add an event, and place the block, the site's styles are severely affected. I'm testing with the Bartik theme, and the fonts are smaller and the layout is completely broken. Looks like the included `paragridma.css` file (758 lines of css!) is way too much for a reusable component like this.

I don't like how the module creates an 'event' content type on install. What if a site already has one? What if a user wants to include other event content types in the calendar? Similarly, I don't like the hardcoded requirement of the field name (jquery_event_calendar_date).

Seems like it would be better offer a config form for the block that lets the user choose the content types and date fields and uses that instead. That would make your module much more flexible and more widely usable.

Changing status.

Besides the aforementioned issue with you working on the master branch, I see some coding standards issues. You are not consistent with your indenting. Indents should be two spaces. Several places you indent 4 or more. Also code on several lines do not align with preceding and subsequent lines. For example: beginning on line 22 of jquery_event_calendar.file.inc,

• Line 22 is indented 4 spaces
• Line 23 is indented 12 spaces
• Line 24 is indented 8 spaces
• Many lines in this file exceed the 80 character limit, per coding standards

Most of this file (jquery_event_calendar.file.inc) is indented using 4 spaces as does jquery_event_calendar_settings.admin.inc, and event_calendar_settings.js.

Major priority is reserved for issues in Needs Review. Once the application is reviewed, the reviewer should set priority back to Normal.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.