Failed to create directory public://print_pdf/print_pdf_tcpdf/cache [#2103095]

Watchdog messages saying Failed to create directory public://print_pdf/print_pdf_tcpdf/cache
This is caused by an error in file_prepare_directory (core) See https://drupal.org/node/2102905#comment-7925581

A workaround until core is fixed is to alter line 66 onwards of print_pdf.module:

    if (isset($info['public_dirs'])) {
      foreach ($info['public_dirs'] as $dir) {
        $directory = drupal_realpath('public://print_pdf/' . $tool[0] . '/' . $dir);
        $result = file_prepare_directory($directory, FILE_CREATE_DIRECTORY);
        if (!$result) {
          watchdog('print_pdf', 'Failed to create directory "%dir" for %tool.', array('%dir' => $directory, '%tool' => $tool[0]), WATCHDOG_CRITICAL);
        }
      }
    }
  }
  if (variable_get('print_pdf_cache_enabled', PRINT_PDF_CACHE_ENABLED_DEFAULT)) {
    $directory = print_pdf_cache_dir();
    $result = file_prepare_directory(drupal_realpath($directory), FILE_MODIFY_PERMISSIONS | FILE_CREATE_DIRECTORY);
    if (!$result) {
      watchdog('print_pdf', 'Failed to create directory "%dir" for print_pdf cache.', array('%dir' => $directory), WATCHDOG_CRITICAL);
    }

Patch to follow

Comment	File	Size	Author
#7	failed_to_create_directory-2103095-7.patch	1.57 KB	alexandrezia
#6	print_pdf-2103095_6.patch	1.36 KB	alexandrezia
#5	print_pdf-2103095_4.patch	1.36 KB	alexandrezia
#3	print_pdf-2103095.patch	1.25 KB	carlhinton
#2	print_pdf-2103095.patch	1.24 KB	carlhinton
#1	print_pdf-2103095.patch	1.26 KB	carlhinton

Comments

Comment #1

carlhinton commented 2 October 2013 at 15:41

Status:

Active

» Needs review

Status	File	Size
new	print_pdf-2103095.patch	1.26 KB

And here is the patch

Comment #2

carlhinton commented 2 October 2013 at 15:50

Status	File	Size
new	print_pdf-2103095.patch	1.24 KB

A better patch attached

Comment #3

carlhinton commented 3 October 2013 at 09:51

Status	File	Size
new	print_pdf-2103095.patch	1.25 KB

An even better patch attached

Comment #4

alexandrezia commented 30 November 2013 at 20:00

Hi, thanks for the patch.
I've made an adjustment because the patch was passing a function by reference and generating a strict warning:
Strict warning: Only variables should be passed by reference in print_pdf_init() (line 69 of /Library/WebServer/Documents/sites/all/modules/contrib/print/print_pdf/print_pdf.module).
Regards

Comment #5

alexandrezia commented 30 November 2013 at 20:03

Issue summary:

View changes

Status	File	Size
new	print_pdf-2103095_4.patch	1.36 KB

Comment #6

alexandrezia commented 30 November 2013 at 20:17

Status	File	Size
new	print_pdf-2103095_6.patch	1.36 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	print_pdf-2103095_4.patch	1.36 KB

Oops, seems like my last patch is not applying, this should work.

Comment #7

alexandrezia commented 7 December 2013 at 20:02

Status	File	Size
new	failed_to_create_directory-2103095-7.patch	1.57 KB

In fact, the path proposed here does not worked for me, it was failing with drush.

As stated by drupal documentation:
The use of drupal_realpath() is discouraged, because it does not work for remote URIs. Except in rare cases, URIs should not be manually resolved.

So I made a new patch that actually works even with drush, using stream wrapper function getDirectoryPath()