Pass "context" and "settings" arguments for every JavaScript "attach" function

We need to fix all occurences of Drupal.settings. Not only a few...

Tried dpm($node); but cannot expand to all data. What exactly does this patch trying fix?

Tried dpm($node); but cannot expand to all data. What exactly does this patch trying fix?

I don't think that the data is not expanding because of this, I think the issue is bigger: #1853112: Replacement for Krumo? meaning that non stdClass such as *everything* now in D8 is not expanded because the same reasons that metadata wrappers or other classes weren't in D7.

Closing #2112747: Dumping with krumo() no longer working? as dupe of this

Updated issue summary.

Some of the conversions happened in #2108403: Big menu sales! hook_menu needs routing now

All Drupal.behaviors attach() functions get passed a "settings" parameter.
Isn't using that argument more appropriate than the global in those contexts?

Anyway, there are only 2 instances of this issue remaining.

+++ b/js/devel_krumo_path.js
@@ -7,7 +7,7 @@ Drupal.behaviors.devel = {
+    $('.krumo-footnote .krumo-call').once().before('<img style="vertical-align: middle;" title="Click to expand. Double-click to show path." src="' + settings.basePath + 'core/misc/help.png"/>');

shouldn't this be drupalSettings?

Well, that was my question in #6.
Is the settings argument to the attach() function not more appropriate in this context?

If not, I don't know what that argument is for.

edit: According to this document, the local settings argument is indeed more appropriate in this context.

Setting as RTBC as for #2128675: JavaScript error on all pages

Yeah, seems is cheaper to use settings if we have it in the context

Looks ok to me.

I think it's the way to go, but I'm getting back to NR as we need further testing with the new changes.

This could be backported to D7 too.

I'd say we can port some of these changes to D7 (proper settings handler instead of Drupal.settings)

Thanks, yannickoo!

You missed two recursive calls to devel_node_access_user_ajax().

With that it's working fine. Wait for the testbot...

No problem, that's why we do reviews.

Pushed to D7.

\o/ thanks @yannickoo @aaronbauman & @salvis =D